diff --git a/packages/ui/src/components/session-review.tsx b/packages/ui/src/components/session-review.tsx index 15464d3ba..7f737032e 100644 --- a/packages/ui/src/components/session-review.tsx +++ b/packages/ui/src/components/session-review.tsx @@ -189,8 +189,10 @@ export const SessionReview = (props: SessionReviewProps) => { const [opened, setOpened] = createSignal(null) const open = () => props.open ?? store.open + const files = createMemo(() => props.diffs.map((d) => d.file)) + const diffs = createMemo(() => new Map(props.diffs.map((d) => [d.file, d] as const))) const diffStyle = () => props.diffStyle ?? (props.split ? "split" : "unified") - const hasDiffs = () => props.diffs.length > 0 + const hasDiffs = () => files().length > 0 const handleChange = (open: string[]) => { props.onOpenChange?.(open) @@ -199,7 +201,7 @@ export const SessionReview = (props: SessionReviewProps) => { } const handleExpandOrCollapseAll = () => { - const next = open().length > 0 ? [] : props.diffs.map((d) => d.file) + const next = open().length > 0 ? [] : files() handleChange(next) } @@ -322,51 +324,54 @@ export const SessionReview = (props: SessionReviewProps) => {
- - {(diff) => { + + {(file) => { let wrapper: HTMLDivElement | undefined - const expanded = createMemo(() => open().includes(diff.file)) + const diff = createMemo(() => diffs().get(file)) + const item = () => diff()! + + const expanded = createMemo(() => open().includes(file)) const [force, setForce] = createSignal(false) - const comments = createMemo(() => (props.comments ?? []).filter((c) => c.file === diff.file)) + const comments = createMemo(() => (props.comments ?? []).filter((c) => c.file === file)) const commentedLines = createMemo(() => comments().map((c) => c.selection)) - const beforeText = () => (typeof diff.before === "string" ? diff.before : "") - const afterText = () => (typeof diff.after === "string" ? diff.after : "") - const changedLines = () => diff.additions + diff.deletions + const beforeText = () => (typeof item().before === "string" ? item().before : "") + const afterText = () => (typeof item().after === "string" ? item().after : "") + const changedLines = () => item().additions + item().deletions const tooLarge = createMemo(() => { if (!expanded()) return false if (force()) return false - if (isImageFile(diff.file)) return false + if (isImageFile(file)) return false return changedLines() > MAX_DIFF_CHANGED_LINES }) - const isAdded = () => diff.status === "added" || (beforeText().length === 0 && afterText().length > 0) + const isAdded = () => item().status === "added" || (beforeText().length === 0 && afterText().length > 0) const isDeleted = () => - diff.status === "deleted" || (afterText().length === 0 && beforeText().length > 0) - const isImage = () => isImageFile(diff.file) - const isAudio = () => isAudioFile(diff.file) + item().status === "deleted" || (afterText().length === 0 && beforeText().length > 0) + const isImage = () => isImageFile(file) + const isAudio = () => isAudioFile(file) - const diffImageSrc = dataUrlFromValue(diff.after) ?? dataUrlFromValue(diff.before) - const [imageSrc, setImageSrc] = createSignal(diffImageSrc) + const diffImageSrc = createMemo(() => dataUrlFromValue(item().after) ?? dataUrlFromValue(item().before)) + const [imageSrc, setImageSrc] = createSignal(diffImageSrc()) const [imageStatus, setImageStatus] = createSignal<"idle" | "loading" | "error">("idle") - const diffAudioSrc = dataUrlFromValue(diff.after) ?? dataUrlFromValue(diff.before) - const [audioSrc, setAudioSrc] = createSignal(diffAudioSrc) + const diffAudioSrc = createMemo(() => dataUrlFromValue(item().after) ?? dataUrlFromValue(item().before)) + const [audioSrc, setAudioSrc] = createSignal(diffAudioSrc()) const [audioStatus, setAudioStatus] = createSignal<"idle" | "loading" | "error">("idle") const [audioMime, setAudioMime] = createSignal(undefined) const selectedLines = createMemo(() => { const current = selection() - if (!current || current.file !== diff.file) return null + if (!current || current.file !== file) return null return current.range }) const draftRange = createMemo(() => { const current = commenting() - if (!current || current.file !== diff.file) return null + if (!current || current.file !== file) return null return current.range }) @@ -417,6 +422,21 @@ export const SessionReview = (props: SessionReviewProps) => { requestAnimationFrame(updateAnchors) } + createEffect(() => { + if (!isImage()) return + const src = diffImageSrc() + setImageSrc(src) + setImageStatus("idle") + }) + + createEffect(() => { + if (!isAudio()) return + const src = diffAudioSrc() + setAudioSrc(src) + setAudioStatus("idle") + setAudioMime(undefined) + }) + createEffect(() => { comments() scheduleAnchors() @@ -430,7 +450,7 @@ export const SessionReview = (props: SessionReviewProps) => { }) createEffect(() => { - if (!open().includes(diff.file)) return + if (!open().includes(file)) return if (!isImage()) return if (imageSrc()) return if (imageStatus() !== "idle") return @@ -440,7 +460,7 @@ export const SessionReview = (props: SessionReviewProps) => { if (!reader) return setImageStatus("loading") - reader(diff.file) + reader(file) .then((result) => { const src = dataUrl(result) if (!src) { @@ -456,7 +476,7 @@ export const SessionReview = (props: SessionReviewProps) => { }) createEffect(() => { - if (!open().includes(diff.file)) return + if (!open().includes(file)) return if (!isAudio()) return if (audioSrc()) return if (audioStatus() !== "idle") return @@ -465,7 +485,7 @@ export const SessionReview = (props: SessionReviewProps) => { if (!reader) return setAudioStatus("loading") - reader(diff.file) + reader(file) .then((result) => { const src = dataUrl(result) if (!src) { @@ -489,7 +509,7 @@ export const SessionReview = (props: SessionReviewProps) => { return } - setSelection({ file: diff.file, range }) + setSelection({ file, range }) } const handleLineSelectionEnd = (range: SelectedLineRange | null) => { @@ -500,8 +520,8 @@ export const SessionReview = (props: SessionReviewProps) => { return } - setSelection({ file: diff.file, range }) - setCommenting({ file: diff.file, range }) + setSelection({ file, range }) + setCommenting({ file, range }) } const openComment = (comment: SessionReviewComment) => { @@ -517,22 +537,22 @@ export const SessionReview = (props: SessionReviewProps) => { return (
- +
- - {`\u202A${getDirectory(diff.file)}\u202C`} + + {`\u202A${getDirectory(file)}\u202C`} - {getFilename(diff.file)} + {getFilename(file)}
@@ -571,7 +591,7 @@ export const SessionReview = (props: SessionReviewProps) => { - + @@ -586,7 +606,7 @@ export const SessionReview = (props: SessionReviewProps) => { data-slot="session-review-diff-wrapper" ref={(el) => { wrapper = el - anchors.set(diff.file, el) + anchors.set(file, el) scheduleAnchors() }} > @@ -594,7 +614,7 @@ export const SessionReview = (props: SessionReviewProps) => {
- {diff.file} + {file}
@@ -634,7 +654,7 @@ export const SessionReview = (props: SessionReviewProps) => { { props.onDiffRendered?.() @@ -646,12 +666,12 @@ export const SessionReview = (props: SessionReviewProps) => { selectedLines={selectedLines()} commentedLines={commentedLines()} before={{ - name: diff.file!, - contents: typeof diff.before === "string" ? diff.before : "", + name: file, + contents: typeof item().before === "string" ? item().before : "", }} after={{ - name: diff.file!, - contents: typeof diff.after === "string" ? diff.after : "", + name: file, + contents: typeof item().after === "string" ? item().after : "", }} /> @@ -689,10 +709,10 @@ export const SessionReview = (props: SessionReviewProps) => { onCancel={() => setCommenting(null)} onSubmit={(comment) => { props.onLineComment?.({ - file: diff.file, + file, selection: range(), comment, - preview: selectionPreview(diff, range()), + preview: selectionPreview(item(), range()), }) setCommenting(null) }}