From 4c9d879624fe4233950fd2365cc190f60e074154 Mon Sep 17 00:00:00 2001 From: adamelmore <2363879+adamdottv@users.noreply.github.com> Date: Mon, 26 Jan 2026 12:09:02 -0600 Subject: [PATCH] Revert "fix(app): restore external link opening in system browser (#10697)" This reverts commit 984518b1c0cb74db0b8eb9f77bb15fb97224a4e2. --- packages/desktop/src/index.tsx | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/packages/desktop/src/index.tsx b/packages/desktop/src/index.tsx index b0ac83307..fe9e3f92e 100644 --- a/packages/desktop/src/index.tsx +++ b/packages/desktop/src/index.tsx @@ -328,23 +328,18 @@ render(() => { const [serverPassword, setServerPassword] = createSignal(null) const platform = createPlatform(() => serverPassword()) - onMount(() => { - // Handle external links - open in system browser instead of webview - const handleClick = (e: MouseEvent) => { - const target = e.target as HTMLElement - const link = target.closest("a") as HTMLAnchorElement | null - - if (link?.href && !link.href.startsWith("javascript:") && !link.href.startsWith("#")) { - e.preventDefault() - e.stopPropagation() - e.stopImmediatePropagation() - void shellOpen(link.href).catch(() => undefined) - } + function handleClick(e: MouseEvent) { + const link = (e.target as HTMLElement).closest("a.external-link") as HTMLAnchorElement | null + if (link?.href) { + e.preventDefault() + platform.openLink(link.href) } + } - document.addEventListener("click", handleClick, true) + onMount(() => { + document.addEventListener("click", handleClick) onCleanup(() => { - document.removeEventListener("click", handleClick, true) + document.removeEventListener("click", handleClick) }) })