refactor(app): dedupe filetree scroll state
This commit is contained in:
@@ -151,6 +151,11 @@ export function SessionSidePanel(props: {
|
|||||||
let changesEl: HTMLDivElement | undefined
|
let changesEl: HTMLDivElement | undefined
|
||||||
let allEl: HTMLDivElement | undefined
|
let allEl: HTMLDivElement | undefined
|
||||||
|
|
||||||
|
const syncFileTreeScrolled = (el?: HTMLDivElement) => {
|
||||||
|
const next = (el?.scrollTop ?? 0) > 0
|
||||||
|
setStore("fileTreeScrolled", (current) => (current === next ? current : next))
|
||||||
|
}
|
||||||
|
|
||||||
const handleDragStart = (event: unknown) => {
|
const handleDragStart = (event: unknown) => {
|
||||||
const id = getDraggableId(event)
|
const id = getDraggableId(event)
|
||||||
if (!id) return
|
if (!id) return
|
||||||
@@ -173,10 +178,7 @@ export function SessionSidePanel(props: {
|
|||||||
|
|
||||||
createEffect(() => {
|
createEffect(() => {
|
||||||
if (!layout.fileTree.opened()) return
|
if (!layout.fileTree.opened()) return
|
||||||
const tab = fileTreeTab()
|
syncFileTreeScrolled(fileTreeTab() === "changes" ? changesEl : allEl)
|
||||||
const el = tab === "changes" ? changesEl : allEl
|
|
||||||
const next = (el?.scrollTop ?? 0) > 0
|
|
||||||
setStore("fileTreeScrolled", (current) => (current === next ? current : next))
|
|
||||||
})
|
})
|
||||||
|
|
||||||
createEffect(() => {
|
createEffect(() => {
|
||||||
@@ -359,11 +361,7 @@ export function SessionSidePanel(props: {
|
|||||||
<Tabs.Content
|
<Tabs.Content
|
||||||
value="changes"
|
value="changes"
|
||||||
ref={(el: HTMLDivElement) => (changesEl = el)}
|
ref={(el: HTMLDivElement) => (changesEl = el)}
|
||||||
onScroll={(e: UIEvent & { currentTarget: HTMLDivElement }) => {
|
onScroll={(e: UIEvent & { currentTarget: HTMLDivElement }) => syncFileTreeScrolled(e.currentTarget)}
|
||||||
if (fileTreeTab() !== "changes") return
|
|
||||||
const next = e.currentTarget.scrollTop > 0
|
|
||||||
setStore("fileTreeScrolled", (current) => (current === next ? current : next))
|
|
||||||
}}
|
|
||||||
class="bg-background-stronger px-3 py-0"
|
class="bg-background-stronger px-3 py-0"
|
||||||
>
|
>
|
||||||
<Switch>
|
<Switch>
|
||||||
@@ -397,11 +395,7 @@ export function SessionSidePanel(props: {
|
|||||||
<Tabs.Content
|
<Tabs.Content
|
||||||
value="all"
|
value="all"
|
||||||
ref={(el: HTMLDivElement) => (allEl = el)}
|
ref={(el: HTMLDivElement) => (allEl = el)}
|
||||||
onScroll={(e: UIEvent & { currentTarget: HTMLDivElement }) => {
|
onScroll={(e: UIEvent & { currentTarget: HTMLDivElement }) => syncFileTreeScrolled(e.currentTarget)}
|
||||||
if (fileTreeTab() !== "all") return
|
|
||||||
const next = e.currentTarget.scrollTop > 0
|
|
||||||
setStore("fileTreeScrolled", (current) => (current === next ? current : next))
|
|
||||||
}}
|
|
||||||
class="bg-background-stronger px-3 py-0"
|
class="bg-background-stronger px-3 py-0"
|
||||||
>
|
>
|
||||||
<FileTree
|
<FileTree
|
||||||
|
|||||||
Reference in New Issue
Block a user