fix: correct /data API usage and data format for importing share URLs (#7381)
This commit is contained in:
@@ -1,17 +1,73 @@
|
|||||||
import type { Argv } from "yargs"
|
import type { Argv } from "yargs"
|
||||||
|
import type { Session as SDKSession, Message, Part } from "@opencode-ai/sdk/v2"
|
||||||
import { Session } from "../../session"
|
import { Session } from "../../session"
|
||||||
import { cmd } from "./cmd"
|
import { cmd } from "./cmd"
|
||||||
import { bootstrap } from "../bootstrap"
|
import { bootstrap } from "../bootstrap"
|
||||||
import { Storage } from "../../storage/storage"
|
import { Storage } from "../../storage/storage"
|
||||||
import { Instance } from "../../project/instance"
|
import { Instance } from "../../project/instance"
|
||||||
|
import { ShareNext } from "../../share/share-next"
|
||||||
import { EOL } from "os"
|
import { EOL } from "os"
|
||||||
|
|
||||||
|
/** Discriminated union returned by the ShareNext API (GET /api/share/:id/data) */
|
||||||
|
export type ShareData =
|
||||||
|
| { type: "session"; data: SDKSession }
|
||||||
|
| { type: "message"; data: Message }
|
||||||
|
| { type: "part"; data: Part }
|
||||||
|
| { type: "session_diff"; data: unknown }
|
||||||
|
| { type: "model"; data: unknown }
|
||||||
|
|
||||||
|
/** Extract share ID from a share URL like https://opncd.ai/share/abc123 */
|
||||||
|
export function parseShareUrl(url: string): string | null {
|
||||||
|
const match = url.match(/^https?:\/\/[^/]+\/share\/([a-zA-Z0-9_-]+)$/)
|
||||||
|
return match ? match[1] : null
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Transform ShareNext API response (flat array) into the nested structure for local file storage.
|
||||||
|
*
|
||||||
|
* The API returns a flat array: [session, message, message, part, part, ...]
|
||||||
|
* Local storage expects: { info: session, messages: [{ info: message, parts: [part, ...] }, ...] }
|
||||||
|
*
|
||||||
|
* This groups parts by their messageID to reconstruct the hierarchy before writing to disk.
|
||||||
|
*/
|
||||||
|
export function transformShareData(shareData: ShareData[]): {
|
||||||
|
info: SDKSession
|
||||||
|
messages: Array<{ info: Message; parts: Part[] }>
|
||||||
|
} | null {
|
||||||
|
const sessionItem = shareData.find((d) => d.type === "session")
|
||||||
|
if (!sessionItem) return null
|
||||||
|
|
||||||
|
const messageMap = new Map<string, Message>()
|
||||||
|
const partMap = new Map<string, Part[]>()
|
||||||
|
|
||||||
|
for (const item of shareData) {
|
||||||
|
if (item.type === "message") {
|
||||||
|
messageMap.set(item.data.id, item.data)
|
||||||
|
} else if (item.type === "part") {
|
||||||
|
if (!partMap.has(item.data.messageID)) {
|
||||||
|
partMap.set(item.data.messageID, [])
|
||||||
|
}
|
||||||
|
partMap.get(item.data.messageID)!.push(item.data)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
if (messageMap.size === 0) return null
|
||||||
|
|
||||||
|
return {
|
||||||
|
info: sessionItem.data,
|
||||||
|
messages: Array.from(messageMap.values()).map((msg) => ({
|
||||||
|
info: msg,
|
||||||
|
parts: partMap.get(msg.id) ?? [],
|
||||||
|
})),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
export const ImportCommand = cmd({
|
export const ImportCommand = cmd({
|
||||||
command: "import <file>",
|
command: "import <file>",
|
||||||
describe: "import session data from JSON file or URL",
|
describe: "import session data from JSON file or URL",
|
||||||
builder: (yargs: Argv) => {
|
builder: (yargs: Argv) => {
|
||||||
return yargs.positional("file", {
|
return yargs.positional("file", {
|
||||||
describe: "path to JSON file or opencode.ai share URL",
|
describe: "path to JSON file or share URL",
|
||||||
type: "string",
|
type: "string",
|
||||||
demandOption: true,
|
demandOption: true,
|
||||||
})
|
})
|
||||||
@@ -22,8 +78,8 @@ export const ImportCommand = cmd({
|
|||||||
| {
|
| {
|
||||||
info: Session.Info
|
info: Session.Info
|
||||||
messages: Array<{
|
messages: Array<{
|
||||||
info: any
|
info: Message
|
||||||
parts: any[]
|
parts: Part[]
|
||||||
}>
|
}>
|
||||||
}
|
}
|
||||||
| undefined
|
| undefined
|
||||||
@@ -31,15 +87,16 @@ export const ImportCommand = cmd({
|
|||||||
const isUrl = args.file.startsWith("http://") || args.file.startsWith("https://")
|
const isUrl = args.file.startsWith("http://") || args.file.startsWith("https://")
|
||||||
|
|
||||||
if (isUrl) {
|
if (isUrl) {
|
||||||
const urlMatch = args.file.match(/https?:\/\/opncd\.ai\/share\/([a-zA-Z0-9_-]+)/)
|
const slug = parseShareUrl(args.file)
|
||||||
if (!urlMatch) {
|
if (!slug) {
|
||||||
process.stdout.write(`Invalid URL format. Expected: https://opncd.ai/share/<slug>`)
|
const baseUrl = await ShareNext.url()
|
||||||
|
process.stdout.write(`Invalid URL format. Expected: ${baseUrl}/share/<slug>`)
|
||||||
process.stdout.write(EOL)
|
process.stdout.write(EOL)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
const slug = urlMatch[1]
|
const baseUrl = await ShareNext.url()
|
||||||
const response = await fetch(`https://opncd.ai/api/share/${slug}`)
|
const response = await fetch(`${baseUrl}/api/share/${slug}/data`)
|
||||||
|
|
||||||
if (!response.ok) {
|
if (!response.ok) {
|
||||||
process.stdout.write(`Failed to fetch share data: ${response.statusText}`)
|
process.stdout.write(`Failed to fetch share data: ${response.statusText}`)
|
||||||
@@ -47,24 +104,16 @@ export const ImportCommand = cmd({
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
const data = await response.json()
|
const shareData: ShareData[] = await response.json()
|
||||||
|
const transformed = transformShareData(shareData)
|
||||||
|
|
||||||
if (!data.info || !data.messages || Object.keys(data.messages).length === 0) {
|
if (!transformed) {
|
||||||
process.stdout.write(`Share not found: ${slug}`)
|
process.stdout.write(`Share not found or empty: ${slug}`)
|
||||||
process.stdout.write(EOL)
|
process.stdout.write(EOL)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
exportData = {
|
exportData = transformed
|
||||||
info: data.info,
|
|
||||||
messages: Object.values(data.messages).map((msg: any) => {
|
|
||||||
const { parts, ...info } = msg
|
|
||||||
return {
|
|
||||||
info,
|
|
||||||
parts,
|
|
||||||
}
|
|
||||||
}),
|
|
||||||
}
|
|
||||||
} else {
|
} else {
|
||||||
const file = Bun.file(args.file)
|
const file = Bun.file(args.file)
|
||||||
exportData = await file.json().catch(() => {})
|
exportData = await file.json().catch(() => {})
|
||||||
|
|||||||
@@ -11,7 +11,7 @@ import type * as SDK from "@opencode-ai/sdk/v2"
|
|||||||
export namespace ShareNext {
|
export namespace ShareNext {
|
||||||
const log = Log.create({ service: "share-next" })
|
const log = Log.create({ service: "share-next" })
|
||||||
|
|
||||||
async function url() {
|
export async function url() {
|
||||||
return Config.get().then((x) => x.enterprise?.url ?? "https://opncd.ai")
|
return Config.get().then((x) => x.enterprise?.url ?? "https://opncd.ai")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
38
packages/opencode/test/cli/import.test.ts
Normal file
38
packages/opencode/test/cli/import.test.ts
Normal file
@@ -0,0 +1,38 @@
|
|||||||
|
import { test, expect } from "bun:test"
|
||||||
|
import { parseShareUrl, transformShareData, type ShareData } from "../../src/cli/cmd/import"
|
||||||
|
|
||||||
|
// parseShareUrl tests
|
||||||
|
test("parses valid share URLs", () => {
|
||||||
|
expect(parseShareUrl("https://opncd.ai/share/Jsj3hNIW")).toBe("Jsj3hNIW")
|
||||||
|
expect(parseShareUrl("https://custom.example.com/share/abc123")).toBe("abc123")
|
||||||
|
expect(parseShareUrl("http://localhost:3000/share/test_id-123")).toBe("test_id-123")
|
||||||
|
})
|
||||||
|
|
||||||
|
test("rejects invalid URLs", () => {
|
||||||
|
expect(parseShareUrl("https://opncd.ai/s/Jsj3hNIW")).toBeNull() // legacy format
|
||||||
|
expect(parseShareUrl("https://opncd.ai/share/")).toBeNull()
|
||||||
|
expect(parseShareUrl("https://opncd.ai/share/id/extra")).toBeNull()
|
||||||
|
expect(parseShareUrl("not-a-url")).toBeNull()
|
||||||
|
})
|
||||||
|
|
||||||
|
// transformShareData tests
|
||||||
|
test("transforms share data to storage format", () => {
|
||||||
|
const data: ShareData[] = [
|
||||||
|
{ type: "session", data: { id: "sess-1", title: "Test" } as any },
|
||||||
|
{ type: "message", data: { id: "msg-1", sessionID: "sess-1" } as any },
|
||||||
|
{ type: "part", data: { id: "part-1", messageID: "msg-1" } as any },
|
||||||
|
{ type: "part", data: { id: "part-2", messageID: "msg-1" } as any },
|
||||||
|
]
|
||||||
|
|
||||||
|
const result = transformShareData(data)!
|
||||||
|
|
||||||
|
expect(result.info.id).toBe("sess-1")
|
||||||
|
expect(result.messages).toHaveLength(1)
|
||||||
|
expect(result.messages[0].parts).toHaveLength(2)
|
||||||
|
})
|
||||||
|
|
||||||
|
test("returns null for invalid share data", () => {
|
||||||
|
expect(transformShareData([])).toBeNull()
|
||||||
|
expect(transformShareData([{ type: "message", data: {} as any }])).toBeNull()
|
||||||
|
expect(transformShareData([{ type: "session", data: { id: "s" } as any }])).toBeNull() // no messages
|
||||||
|
})
|
||||||
Reference in New Issue
Block a user