diff --git a/packages/app/src/pages/session.tsx b/packages/app/src/pages/session.tsx index c5997193f..2fc4ab62c 100644 --- a/packages/app/src/pages/session.tsx +++ b/packages/app/src/pages/session.tsx @@ -316,12 +316,22 @@ export default function Page() { return sync.session.history.loading(id) }) const emptyUserMessages: UserMessage[] = [] - const userMessages = createMemo(() => messages().filter((m) => m.role === "user") as UserMessage[], emptyUserMessages) - const visibleUserMessages = createMemo(() => { - const revert = revertMessageID() - if (!revert) return userMessages() - return userMessages().filter((m) => m.id < revert) - }, emptyUserMessages) + const userMessages = createMemo( + () => messages().filter((m) => m.role === "user") as UserMessage[], + emptyUserMessages, + { equals: same }, + ) + const visibleUserMessages = createMemo( + () => { + const revert = revertMessageID() + if (!revert) return userMessages() + return userMessages().filter((m) => m.id < revert) + }, + emptyUserMessages, + { + equals: same, + }, + ) const lastUserMessage = createMemo(() => visibleUserMessages().at(-1)) createEffect( @@ -347,13 +357,19 @@ export default function Page() { promptHeight: 0, }) - const renderedUserMessages = createMemo(() => { - const msgs = visibleUserMessages() - const start = store.turnStart - if (start <= 0) return msgs - if (start >= msgs.length) return emptyUserMessages - return msgs.slice(start) - }, emptyUserMessages) + const renderedUserMessages = createMemo( + () => { + const msgs = visibleUserMessages() + const start = store.turnStart + if (start <= 0) return msgs + if (start >= msgs.length) return emptyUserMessages + return msgs.slice(start) + }, + emptyUserMessages, + { + equals: same, + }, + ) const newSessionWorktree = createMemo(() => { if (store.newSessionWorktree === "create") return "create" diff --git a/packages/ui/src/components/session-turn.tsx b/packages/ui/src/components/session-turn.tsx index ca63d17ab..fe53c0939 100644 --- a/packages/ui/src/components/session-turn.tsx +++ b/packages/ui/src/components/session-turn.tsx @@ -457,9 +457,16 @@ export function SessionTurn( }) createEffect(() => { - const timer = setInterval(() => { + const update = () => { setStore("duration", duration()) - }, 1000) + } + + update() + + // Only keep ticking while the active (in-progress) turn is running. + if (!working()) return + + const timer = setInterval(update, 1000) onCleanup(() => clearInterval(timer)) }) @@ -495,6 +502,11 @@ export function SessionTurn( } }) + onCleanup(() => { + if (!statusTimeout) return + clearTimeout(statusTimeout) + }) + return (