From e9152b174f747ac52e567423f4416cb871da0265 Mon Sep 17 00:00:00 2001 From: adamelmore <2363879+adamdottv@users.noreply.github.com> Date: Sun, 25 Jan 2026 06:50:27 -0600 Subject: [PATCH] fix(app): comment line placement in diffs --- packages/ui/src/components/session-review.tsx | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/packages/ui/src/components/session-review.tsx b/packages/ui/src/components/session-review.tsx index 1ae0b1a13..42c0bc2aa 100644 --- a/packages/ui/src/components/session-review.tsx +++ b/packages/ui/src/components/session-review.tsx @@ -123,11 +123,17 @@ type SessionReviewSelection = { range: SelectedLineRange } -function findSide(element: HTMLElement): "additions" | "deletions" { +function findSide(element: HTMLElement): "additions" | "deletions" | undefined { + const typed = element.closest("[data-line-type]") + if (typed instanceof HTMLElement) { + const type = typed.dataset.lineType + if (type === "change-deletion") return "deletions" + if (type === "change-addition" || type === "change-additions") return "additions" + } + const code = element.closest("[data-code]") - if (!(code instanceof HTMLElement)) return "additions" - if (code.hasAttribute("data-deletions")) return "deletions" - return "additions" + if (!(code instanceof HTMLElement)) return + return code.hasAttribute("data-deletions") ? "deletions" : "additions" } function findMarker(root: ShadowRoot, range: SelectedLineRange) {