From d42af870ff56112b4503f2568b8a5b0f385c435c Mon Sep 17 00:00:00 2001 From: Mathieu Virbel Date: Tue, 11 Mar 2025 12:15:40 -0600 Subject: [PATCH] fix(goose): remove MCP_HOST and such, this is not how mcp works --- SPECIFICATIONS.md | 2 -- drivers/goose/README.md | 8 ++------ drivers/goose/mc-driver.yaml | 6 +----- drivers/goose/mc-init.sh | 6 ------ 4 files changed, 3 insertions(+), 19 deletions(-) diff --git a/SPECIFICATIONS.md b/SPECIFICATIONS.md index f85431c..435449b 100644 --- a/SPECIFICATIONS.md +++ b/SPECIFICATIONS.md @@ -236,8 +236,6 @@ logging: drivers: - name: goose image: monadical/mc-goose:latest - env: - MCP_HOST: http://mcp:8000 - name: aider image: monadical/mc-aider:latest - name: claude-code diff --git a/drivers/goose/README.md b/drivers/goose/README.md index 204f9a4..16067e7 100644 --- a/drivers/goose/README.md +++ b/drivers/goose/README.md @@ -1,11 +1,11 @@ # Goose Driver for MC -This driver provides a containerized environment for running [Goose](https://goose.ai) with MCP servers. +This driver provides a containerized environment for running [Goose](https://goose.ai). ## Features - Pre-configured environment for Goose AI -- MCP server integration +- Self-hosted instance integration - SSH access - Git repository integration - Langfuse logging support @@ -14,7 +14,6 @@ This driver provides a containerized environment for running [Goose](https://goo | Variable | Description | Required | |----------|-------------|----------| -| `MCP_HOST` | MCP server host | Yes | | `LANGFUSE_INIT_PROJECT_PUBLIC_KEY` | Langfuse public key | No | | `LANGFUSE_INIT_PROJECT_SECRET_KEY` | Langfuse secret key | No | | `LANGFUSE_URL` | Langfuse API URL | No | @@ -37,9 +36,6 @@ docker build -t monadical/mc-goose:latest . # Create a new session with this driver mc session create --driver goose -# Create with specific MCP server -mc session create --driver goose -e MCP_HOST=http://mcp.example.com:8000 - # Create with project repository mc session create --driver goose --project github.com/username/repo ``` \ No newline at end of file diff --git a/drivers/goose/mc-driver.yaml b/drivers/goose/mc-driver.yaml index 99ba1dd..8b4b2d1 100644 --- a/drivers/goose/mc-driver.yaml +++ b/drivers/goose/mc-driver.yaml @@ -1,5 +1,5 @@ name: goose -description: Goose with MCP servers +description: Goose AI environment version: 1.0.0 maintainer: team@monadical.com @@ -8,10 +8,6 @@ init: command: /entrypoint.sh environment: - - name: MCP_HOST - description: MCP server host - required: true - default: http://localhost:8000 - name: LANGFUSE_INIT_PROJECT_PUBLIC_KEY description: Langfuse public key diff --git a/drivers/goose/mc-init.sh b/drivers/goose/mc-init.sh index 9c7fa6f..b2dc631 100755 --- a/drivers/goose/mc-init.sh +++ b/drivers/goose/mc-init.sh @@ -72,12 +72,6 @@ fi # Goose uses self-hosted instance, no API key required -# Set up MCP connection if provided -if [ -n "$MCP_HOST" ]; then - echo "Setting up MCP connection to $MCP_HOST" - export MCP_HOST="$MCP_HOST" -fi - # Set up Langfuse logging if credentials are provided if [ -n "$LANGFUSE_INIT_PROJECT_SECRET_KEY" ] && [ -n "$LANGFUSE_INIT_PROJECT_PUBLIC_KEY" ]; then echo "Setting up Langfuse logging"