doc update (vibe)

server/reflector/video_platforms/__init__.py

@@ -5,7 +5,8 @@ It allows seamless switching between providers (Whereby, Daily.co, etc.) without
 changing the core application logic.
 """
 
-from .base import MeetingData, VideoPlatformClient, VideoPlatformConfig
+from .base import VideoPlatformClient
+from .models import MeetingData, VideoPlatformConfig
 from .registry import get_platform_client, register_platform
 
 __all__ = [

server/reflector/video_platforms/base.py

@@ -1,39 +1,14 @@
 from abc import ABC, abstractmethod
 from datetime import datetime
-from typing import TYPE_CHECKING, Any, Dict, Literal, Optional
-
-from pydantic import BaseModel
+from typing import TYPE_CHECKING, Any, Dict, Optional
 
 from reflector.platform_types import Platform
 
+from .models import MeetingData, VideoPlatformConfig
+
 if TYPE_CHECKING:
     from reflector.db.rooms import Room
 
-RecordingType = Literal["none", "local", "cloud"]
-
-
-class MeetingData(BaseModel):
-    meeting_id: str
-    room_name: str
-    room_url: str
-    host_room_url: str
-    platform: Platform
-    extra_data: Dict[str, Any] = {}
-
-
-class VideoPlatformConfig(BaseModel):
-    """Configuration for a video platform."""
-
-    api_key: str
-    webhook_secret: str
-    api_url: Optional[str] = None
-    subdomain: Optional[str] = None
-    s3_bucket: Optional[str] = None
-    s3_region: Optional[str] = None
-    aws_role_arn: Optional[str] = None
-    aws_access_key_id: Optional[str] = None
-    aws_access_key_secret: Optional[str] = None
-
 
 class VideoPlatformClient(ABC):
     """Abstract base class for video platform integrations."""

server/reflector/video_platforms/daily.py

@@ -58,13 +58,14 @@ class DailyClient(VideoPlatformClient):
         }
 
         # Configure S3 bucket for recordings
-        if room.recording_type != self.RECORDING_NONE and self.config.s3_bucket:
-            data["properties"]["recordings_bucket"] = {
-                "bucket_name": self.config.s3_bucket,
-                "bucket_region": self.config.s3_region,
-                "assume_role_arn": self.config.aws_role_arn,
-                "allow_api_access": True,
-            }
+        # NOTE: Not checking room.recording_type - figure out later if conditional needed
+        assert self.config.s3_bucket, "S3 bucket must be configured"
+        data["properties"]["recordings_bucket"] = {
+            "bucket_name": self.config.s3_bucket,
+            "bucket_region": self.config.s3_region,
+            "assume_role_arn": self.config.aws_role_arn,
+            "allow_api_access": True,
+        }
 
         from reflector.logger import logger
 

server/reflector/video_platforms/models.py

@@ -0,0 +1,49 @@
+"""Video platform data models.
+
+Standard data models used across all video platform implementations.
+"""
+
+from typing import Any, Dict, Literal, Optional
+
+from pydantic import BaseModel, Field
+
+from reflector.platform_types import Platform
+
+RecordingType = Literal["none", "local", "cloud"]
+
+
+class MeetingData(BaseModel):
+    """Standardized meeting data returned by all providers."""
+
+    platform: Platform
+    meeting_id: str = Field(description="Platform-specific meeting identifier")
+    room_url: str = Field(description="URL for participants to join")
+    host_room_url: str = Field(description="URL for hosts (may be same as room_url)")
+    room_name: str = Field(description="Human-readable room name")
+    extra_data: Dict[str, Any] = Field(default_factory=dict)
+
+    class Config:
+        json_schema_extra = {
+            "example": {
+                "platform": "whereby",
+                "meeting_id": "12345678",
+                "room_url": "https://subdomain.whereby.com/room-20251008120000",
+                "host_room_url": "https://subdomain.whereby.com/room-20251008120000?roomKey=abc123",
+                "room_name": "room-20251008120000",
+            }
+        }
+
+
+class VideoPlatformConfig(BaseModel):
+    """Platform-agnostic configuration model."""
+
+    api_key: str
+    webhook_secret: str
+    api_url: Optional[str] = None
+    subdomain: Optional[str] = None  # Whereby/Daily subdomain
+    s3_bucket: Optional[str] = None
+    s3_region: Optional[str] = None
+    # Whereby uses access keys, Daily uses IAM role
+    aws_access_key_id: Optional[str] = None
+    aws_access_key_secret: Optional[str] = None
+    aws_role_arn: Optional[str] = None