self-review-fix

www/app/(app)/browse/_components/FilterSidebar.tsx

@@ -98,7 +98,7 @@ export default function FilterSidebar({
         <Link
           as={NextLink}
           href="#"
-          onClick={() => onFilterChange("live" as SourceKind, "")}
+          onClick={() => onFilterChange("live", "")}
           color={selectedSourceKind === "live" ? "blue.500" : "gray.600"}
           _hover={{ color: "blue.300" }}
           fontWeight={selectedSourceKind === "live" ? "bold" : "normal"}
@@ -109,7 +109,7 @@ export default function FilterSidebar({
         <Link
           as={NextLink}
           href="#"
-          onClick={() => onFilterChange("file" as SourceKind, "")}
+          onClick={() => onFilterChange("file", "")}
           color={selectedSourceKind === "file" ? "blue.500" : "gray.600"}
           _hover={{ color: "blue.300" }}
           fontWeight={selectedSourceKind === "file" ? "bold" : "normal"}

www/app/(app)/browse/page.tsx

@@ -42,7 +42,7 @@ import Pagination, {
 import TranscriptCards from "./_components/TranscriptCards";
 import DeleteTranscriptDialog from "./_components/DeleteTranscriptDialog";
 import { formatLocalDate } from "../../lib/time";
-import { RECORD_A_MEETING_URL } from "../../lib/constants";
+import { RECORD_A_MEETING_URL } from "../../api/urls";
 
 const SEARCH_FORM_QUERY_INPUT_NAME = "query" as const;
 
@@ -298,24 +298,11 @@ export default function TranscriptBrowser() {
   };
 
   const handleProcessTranscript = (transcriptId: string) => {
-    processTranscript.mutate(
-      {
-        params: {
-          path: { transcript_id: transcriptId },
-        },
+    processTranscript.mutate({
+      params: {
+        path: { transcript_id: transcriptId },
       },
-      {
-        onSuccess: (result) => {
-          const status =
-            result && typeof result === "object" && "status" in result
-              ? (result as { status: string }).status
-              : undefined;
-          if (status === "already running") {
-            // Note: setError is already handled in the hook
-          }
-        },
-      },
-    );
+    });
   };
 
   const transcriptToDelete = results?.find(

www/app/(app)/layout.tsx

@@ -2,11 +2,9 @@ import { Container, Flex, Link } from "@chakra-ui/react";
 import { getConfig } from "../lib/edgeConfig";
 import NextLink from "next/link";
 import Image from "next/image";
-import About from "../(aboutAndPrivacy)/about";
-import Privacy from "../(aboutAndPrivacy)/privacy";
 import UserInfo from "../(auth)/userInfo";
 import AuthWrapper from "./AuthWrapper";
-import { RECORD_A_MEETING_URL } from "../lib/constants";
+import { RECORD_A_MEETING_URL } from "../api/urls";
 
 export default async function AppLayout({
   children,

www/app/(app)/transcripts/new/page.tsx

@@ -35,7 +35,9 @@ import {
 const TranscriptCreate = () => {
   const isClient = typeof window !== "undefined";
   const router = useRouter();
-  const { isLoading, isAuthenticated } = useSessionStatus();
+  const status = useSessionStatus();
+  const isAuthenticated = status === "authenticated";
+  const isLoading = status === "loading";
   const requireLogin = featureEnabled("requireLogin");
 
   const [name, setName] = useState<string>("");

www/app/(app)/transcripts/recorder.tsx

@@ -6,12 +6,11 @@ import RecordPlugin from "../../lib/custom-plugins/record";
 import { formatTime, formatTimeMs } from "../../lib/time";
 import { waveSurferStyles } from "../../styles/recorder";
 import { useError } from "../../(errors)/errorContext";
-import FileUploadButton from "./fileUploadButton";
 import useWebRTC from "./useWebRTC";
 import useAudioDevice from "./useAudioDevice";
 import { Box, Flex, IconButton, Menu, RadioGroup } from "@chakra-ui/react";
 import { LuScreenShare, LuMic, LuPlay, LuCircleStop } from "react-icons/lu";
-import { RECORD_A_MEETING_URL } from "../../lib/constants";
+import { RECORD_A_MEETING_URL } from "../../api/urls";
 
 type RecorderProps = {
   transcriptId: string;

www/app/(app)/transcripts/shareZulip.tsx

@@ -43,7 +43,6 @@ export default function ShareZulip(props: ShareZulipProps & BoxProps) {
   const [topic, setTopic] = useState<string | undefined>(undefined);
   const [includeTopics, setIncludeTopics] = useState(false);
 
-  // React Query hooks
   const { data: streams = [], isLoading: isLoadingStreams } = useZulipStreams();
   const { data: topics = [] } = useZulipTopics(selectedStreamId);
   const postToZulipMutation = useTranscriptPostToZulip();

www/app/(app)/transcripts/useMp3.ts

@@ -2,6 +2,7 @@ import { useContext, useEffect, useState } from "react";
 import { DomainContext } from "../../domainContext";
 import { useTranscriptGet } from "../../lib/apiHooks";
 import { useSession } from "next-auth/react";
+import { assertExtendedToken } from "../../lib/types";
 
 export type Mp3Response = {
   media: HTMLMediaElement | null;
@@ -21,9 +22,11 @@ const useMp3 = (transcriptId: string, waiting?: boolean): Mp3Response => {
   const [audioDeleted, setAudioDeleted] = useState<boolean | null>(null);
   const { api_url } = useContext(DomainContext);
   const { data: session } = useSession();
-  const accessTokenInfo = (session as any)?.accessToken as string | undefined;
+  const sessionExtended =
+    session === null ? null : assertExtendedToken(session);
+  const accessTokenInfo =
+    sessionExtended === null ? null : sessionExtended.accessToken;
 
-  // Use React Query to fetch transcript metadata
   const {
     data: transcript,
     isLoading: transcriptMetadataLoading,

www/app/(app)/transcripts/useSearchTranscripts.ts

@@ -1,53 +0,0 @@
-// Wrapper for backward compatibility
-import type { components } from "../../reflector-api";
-type SearchResult = components["schemas"]["SearchResult"];
-type SourceKind = components["schemas"]["SourceKind"];
-import { useTranscriptsSearch } from "../../lib/apiHooks";
-import {
-  PaginationPage,
-  paginationPageTo0Based,
-} from "../browse/_components/Pagination";
-
-interface SearchFilters {
-  roomIds: readonly string[] | null;
-  sourceKind: SourceKind | null;
-}
-
-type UseSearchTranscriptsOptions = {
-  pageSize: number;
-  page: PaginationPage;
-};
-
-interface UseSearchTranscriptsReturn {
-  results: SearchResult[];
-  totalCount: number;
-  isLoading: boolean;
-  error: unknown;
-  reload: () => void;
-}
-
-export function useSearchTranscripts(
-  query: string = "",
-  filters: SearchFilters = { roomIds: null, sourceKind: null },
-  options: UseSearchTranscriptsOptions = {
-    pageSize: 20,
-    page: PaginationPage(1),
-  },
-): UseSearchTranscriptsReturn {
-  const { pageSize, page } = options;
-
-  const { data, isLoading, error, refetch } = useTranscriptsSearch(query, {
-    limit: pageSize,
-    offset: paginationPageTo0Based(page) * pageSize,
-    room_id: filters.roomIds?.[0],
-    source_kind: filters.sourceKind || undefined,
-  });
-
-  return {
-    results: data?.results || [],
-    totalCount: data?.total || 0,
-    isLoading,
-    error,
-    reload: refetch,
-  };
-}

www/app/(app)/transcripts/useWebSockets.ts

@@ -37,7 +37,7 @@ export const useWebSockets = (transcriptId: string | null): UseWebSockets => {
   const [status, setStatus] = useState<Status>({ value: "" });
   const { setError } = useError();
 
-  const { websocket_url } = useContext(DomainContext);
+  const { websocket_url: websocketUrl } = useContext(DomainContext);
   const queryClient = useQueryClient();
 
   const [accumulatedText, setAccumulatedText] = useState<string>("");
@@ -328,7 +328,7 @@ export const useWebSockets = (transcriptId: string | null): UseWebSockets => {
 
     if (!transcriptId) return;
 
-    const url = `${websocket_url}/v1/transcripts/${transcriptId}/events`;
+    const url = `${websocketUrl}/v1/transcripts/${transcriptId}/events`;
     let ws = new WebSocket(url);
 
     ws.onopen = () => {
@@ -489,7 +489,7 @@ export const useWebSockets = (transcriptId: string | null): UseWebSockets => {
     return () => {
       ws.close();
     };
-  }, [transcriptId, websocket_url, queryClient]);
+  }, [transcriptId, websocketUrl, queryClient]);
 
   return {
     transcriptTextLive,