From 238d76849900784be2f1d0c9bab4552f140595d3 Mon Sep 17 00:00:00 2001 From: Igor Loskutov Date: Thu, 5 Feb 2026 18:50:12 -0500 Subject: [PATCH] fix: address review feedback - use ApiError type, move inline imports --- server/tests/test_ics_dedup.py | 5 +---- www/app/[roomName]/components/DailyRoom.tsx | 8 ++------ 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/server/tests/test_ics_dedup.py b/server/tests/test_ics_dedup.py index ce7d299b..4c03822e 100644 --- a/server/tests/test_ics_dedup.py +++ b/server/tests/test_ics_dedup.py @@ -3,6 +3,7 @@ from unittest.mock import AsyncMock, patch import pytest +from reflector.db import get_database from reflector.db.calendar_events import CalendarEvent, calendar_events_controller from reflector.db.meetings import meetings from reflector.db.rooms import rooms_controller @@ -64,8 +65,6 @@ async def test_duplicate_calendar_event_does_not_create_duplicate_meeting(): await create_upcoming_meetings_for_event(event1, create_window, room) # Verify meeting was created - from reflector.db import get_database - results = await get_database().fetch_all( meetings.select().where(meetings.c.room_id == room.id) ) @@ -176,8 +175,6 @@ async def test_different_time_windows_create_separate_meetings(): await create_upcoming_meetings_for_event(event1, create_window, room) await create_upcoming_meetings_for_event(event2, create_window, room) - from reflector.db import get_database - results = await get_database().fetch_all( meetings.select().where(meetings.c.room_id == room.id) ) diff --git a/www/app/[roomName]/components/DailyRoom.tsx b/www/app/[roomName]/components/DailyRoom.tsx index e6eccfc4..02feafbc 100644 --- a/www/app/[roomName]/components/DailyRoom.tsx +++ b/www/app/[roomName]/components/DailyRoom.tsx @@ -21,7 +21,7 @@ import DailyIframe, { DailyParticipantsObject, } from "@daily-co/daily-js"; import type { components } from "../../reflector-api"; -import { printApiError } from "../../api/_error"; +import { printApiError, ApiError } from "../../api/_error"; import { useAuth } from "../../lib/AuthProvider"; import { useConsentDialog } from "../../lib/consent"; import { @@ -401,11 +401,7 @@ export default function DailyRoom({ meeting, room }: DailyRoomProps) { } if (joinMutation.isError) { - const apiDetail = printApiError( - joinMutation.error as { - detail?: components["schemas"]["ValidationError"][]; - } | null, - ); + const apiDetail = printApiError(joinMutation.error as ApiError); return (