From 2b723da08bd8f1e037cb769285abd3d57463905a Mon Sep 17 00:00:00 2001
From: Igor Monadical <igor@monadical.com>
Date: Wed, 17 Sep 2025 20:02:17 -0400
Subject: [PATCH] rooms-page-calendar-ics-room-name-fix (#659)

Co-authored-by: Igor Loskutov <igor.loskutoff@gmail.com>
---
 .../(app)/rooms/_components/ICSSettings.tsx   | 54 ++++++++++---------
 www/app/(app)/rooms/page.tsx                  |  2 +-
 2 files changed, 29 insertions(+), 27 deletions(-)

diff --git a/www/app/(app)/rooms/_components/ICSSettings.tsx b/www/app/(app)/rooms/_components/ICSSettings.tsx
index 1fa97692..9b45ff33 100644
--- a/www/app/(app)/rooms/_components/ICSSettings.tsx
+++ b/www/app/(app)/rooms/_components/ICSSettings.tsx
@@ -27,7 +27,7 @@ import {
 } from "../../../lib/utils";
 
 interface ICSSettingsProps {
-  roomName: NonEmptyString;
+  roomName: NonEmptyString | null;
   icsUrl?: string;
   icsEnabled?: boolean;
   icsFetchInterval?: number;
@@ -85,7 +85,7 @@ export default function ICSSettings({
   const handleCopyRoomUrl = async () => {
     try {
       await navigator.clipboard.writeText(
-        roomAbsoluteUrl(assertExistsAndNonEmptyString(roomName)),
+        roomAbsoluteUrl(assertExists(roomName)),
       );
       setJustCopied(true);
 
@@ -123,7 +123,7 @@ export default function ICSSettings({
   const handleRoomUrlClick = () => {
     if (roomUrlInputRef.current) {
       roomUrlInputRef.current.select();
-      handleCopyRoomUrl();
+      handleCopyRoomUrl().then(() => {});
     }
   };
 
@@ -196,30 +196,32 @@ export default function ICSSettings({
               To enable Reflector to recognize your calendar events as meetings,
               add this URL as the location in your calendar events
             </Field.HelperText>
-            <HStack gap={0} position="relative" width="100%">
-              <Input
-                ref={roomUrlInputRef}
-                value={roomAbsoluteUrl(parseNonEmptyString(roomName))}
-                readOnly
-                onClick={handleRoomUrlClick}
-                cursor="pointer"
-                bg="gray.100"
-                _hover={{ bg: "gray.200" }}
-                _focus={{ bg: "gray.200" }}
-                pr="90px"
-                width="100%"
-              />
-              <HStack position="absolute" right="4px" gap={1} zIndex={1}>
-                <IconButton
-                  aria-label="Copy room URL"
-                  onClick={handleCopyRoomUrl}
-                  variant="ghost"
-                  size="sm"
-                >
-                  {justCopied ? <LuCheck /> : <LuCopy />}
-                </IconButton>
+            {roomName ? (
+              <HStack gap={0} position="relative" width="100%">
+                <Input
+                  ref={roomUrlInputRef}
+                  value={roomAbsoluteUrl(parseNonEmptyString(roomName))}
+                  readOnly
+                  onClick={handleRoomUrlClick}
+                  cursor="pointer"
+                  bg="gray.100"
+                  _hover={{ bg: "gray.200" }}
+                  _focus={{ bg: "gray.200" }}
+                  pr="90px"
+                  width="100%"
+                />
+                <HStack position="absolute" right="4px" gap={1} zIndex={1}>
+                  <IconButton
+                    aria-label="Copy room URL"
+                    onClick={handleCopyRoomUrl}
+                    variant="ghost"
+                    size="sm"
+                  >
+                    {justCopied ? <LuCheck /> : <LuCopy />}
+                  </IconButton>
+                </HStack>
               </HStack>
-            </HStack>
+            ) : null}
           </Field.Root>
 
           <Field.Root>
diff --git a/www/app/(app)/rooms/page.tsx b/www/app/(app)/rooms/page.tsx
index 88e66720..9de5950a 100644
--- a/www/app/(app)/rooms/page.tsx
+++ b/www/app/(app)/rooms/page.tsx
@@ -624,7 +624,7 @@ export default function RoomsList() {
 
                 <Tabs.Content value="calendar" pt={6}>
                   <ICSSettings
-                    roomName={parseNonEmptyString(room.name)}
+                    roomName={room.name ? parseNonEmptyString(room.name) : null}
                     icsUrl={room.icsUrl}
                     icsEnabled={room.icsEnabled}
                     icsFetchInterval={room.icsFetchInterval}