This commit is contained in:
Igor Loskutov
2026-01-13 12:44:43 -05:00
parent 68df825734
commit 3652de9fca
5 changed files with 156 additions and 69 deletions

View File

@@ -5,10 +5,28 @@
"created_at": "2026-01-12T22:41:17.996329Z",
"depends_on": [],
"epic": "fn-1",
"evidence": {
"commits": [
"68df8257"
],
"files_changed": [
".flow/tasks/fn-1.8.json",
".flow/tasks/fn-1.8.md",
"server/tests/test_transcripts_chat.py"
],
"tests": [
"test_chat_websocket_connection_success",
"test_chat_websocket_nonexistent_transcript",
"test_chat_websocket_multiple_messages",
"test_chat_websocket_disconnect_graceful",
"test_chat_websocket_context_generation",
"test_chat_websocket_unknown_message_type"
]
},
"id": "fn-1.8",
"priority": null,
"spec_path": ".flow/tasks/fn-1.8.md",
"status": "in_progress",
"status": "done",
"title": "End-to-end testing",
"updated_at": "2026-01-13T01:10:06.678981Z"
"updated_at": "2026-01-13T01:18:10.893171Z"
}

View File

@@ -19,18 +19,25 @@ Fix WebSocket chat tests to use proper async WebSocket testing approach (matchin
- [x] No event loop or asyncio errors in test output
## Done summary
Fixed WebSocket chat tests by switching from TestClient to proper async testing with httpx_ws and threaded server pattern. All 6 tests now pass without event loop errors.
Fixed WebSocket chat tests by switching from TestClient (which has event loop issues) to proper async testing approach using httpx_ws and threaded server pattern (matching existing test_transcripts_rtc_ws.py).
## Changes
- Rewrote all WebSocket tests to use aconnect_ws from httpx_ws
- Added chat_appserver fixture using threaded Uvicorn server (port 1256)
- Tests now use separate event loop in server thread
- Matches existing pattern from test_transcripts_rtc_ws.py
## Tests Passing
All 6 tests now pass:
- test_chat_websocket_connection_success: validates WebSocket connection and echo behavior
- test_chat_websocket_nonexistent_transcript: validates error handling for invalid transcript
- test_chat_websocket_multiple_messages: validates handling multiple sequential messages
- test_chat_websocket_disconnect_graceful: validates clean disconnection
- test_chat_websocket_context_generation: validates WebVTT context generation with participants/words
- test_chat_websocket_unknown_message_type: validates echo behavior for unknown message types
1. test_chat_websocket_connection_success - validates WebSocket connection and echo behavior
2. test_chat_websocket_nonexistent_transcript - validates error handling for invalid transcript
3. test_chat_websocket_multiple_messages - validates handling multiple sequential messages
4. test_chat_websocket_disconnect_graceful - validates clean disconnection
5. test_chat_websocket_context_generation - validates WebVTT context generation
6. test_chat_websocket_unknown_message_type - validates echo for unknown message types
## Evidence
- Commits:
- Tests:
- PRs:
- Commits: 68df8257
- Tests: test_chat_websocket_connection_success, test_chat_websocket_nonexistent_transcript, test_chat_websocket_multiple_messages, test_chat_websocket_disconnect_graceful, test_chat_websocket_context_generation, test_chat_websocket_unknown_message_type
- PRs: