This commit is contained in:
Igor Loskutov
2025-12-16 16:44:15 -05:00
parent c280e8dc1d
commit 447bf97854
4 changed files with 9 additions and 8 deletions

View File

@@ -54,6 +54,7 @@ class ValidationOk:
# transcript currently doesnt always have recording_id # transcript currently doesnt always have recording_id
recording_id: NonEmptyString | None recording_id: NonEmptyString | None
transcript_id: NonEmptyString transcript_id: NonEmptyString
room_id: NonEmptyString | None = None
@dataclass @dataclass
@@ -129,13 +130,13 @@ async def validate_transcript_for_processing(
pass pass
return ValidationOk( return ValidationOk(
recording_id=transcript.recording_id, transcript_id=transcript.id recording_id=transcript.recording_id,
transcript_id=transcript.id,
room_id=transcript.room_id,
) )
async def prepare_transcript_processing( async def prepare_transcript_processing(validation: ValidationOk) -> PrepareResult:
validation: ValidationOk, room_id: str | None = None
) -> PrepareResult:
""" """
Determine processing mode from transcript/recording data. Determine processing mode from transcript/recording data.
""" """
@@ -164,7 +165,7 @@ async def prepare_transcript_processing(
track_keys=track_keys, track_keys=track_keys,
transcript_id=validation.transcript_id, transcript_id=validation.transcript_id,
recording_id=recording_id, recording_id=recording_id,
room_id=room_id, room_id=validation.room_id,
) )
return FileProcessingConfig( return FileProcessingConfig(

View File

@@ -38,7 +38,7 @@ async def process_transcript_inner(
) -> AsyncResult: ) -> AsyncResult:
validation = await validate_transcript_for_processing(transcript) validation = await validate_transcript_for_processing(transcript)
on_validation(validation) on_validation(validation)
config = await prepare_transcript_processing(validation, room_id=transcript.room_id) config = await prepare_transcript_processing(validation)
on_preprocess(config) on_preprocess(config)
return dispatch_transcript_processing(config, force=force) return dispatch_transcript_processing(config, force=force)

View File

@@ -45,7 +45,7 @@ async def transcript_process(
else: else:
assert_never(validation) assert_never(validation)
config = await prepare_transcript_processing(validation, room_id=transcript.room_id) config = await prepare_transcript_processing(validation)
if isinstance(config, ProcessError): if isinstance(config, ProcessError):
raise HTTPException(status_code=500, detail=config.detail) raise HTTPException(status_code=500, detail=config.detail)

View File

@@ -332,7 +332,7 @@ async def test_prepare_multitrack_config():
) as mock_rc: ) as mock_rc:
mock_rc.get_by_id = AsyncMock(return_value=mock_recording) mock_rc.get_by_id = AsyncMock(return_value=mock_recording)
result = await prepare_transcript_processing(validation, room_id="test-room") result = await prepare_transcript_processing(validation)
assert isinstance(result, MultitrackProcessingConfig) assert isinstance(result, MultitrackProcessingConfig)
assert result.bucket_name == "test-bucket" assert result.bucket_name == "test-bucket"