Merge remote-tracking branch 'origin/main' into mathieu/sqlalchemy-2-migration

CHANGELOG.md

@@ -1,5 +1,24 @@
 # Changelog
 
+## [0.13.1](https://github.com/Monadical-SAS/reflector/compare/v0.13.0...v0.13.1) (2025-09-22)
+
+
+### Bug Fixes
+
+* TypeError on not all arguments converted during string formatting in logger ([#667](https://github.com/Monadical-SAS/reflector/issues/667)) ([565a629](https://github.com/Monadical-SAS/reflector/commit/565a62900f5a02fc946b68f9269a42190ed70ab6))
+
+## [0.13.0](https://github.com/Monadical-SAS/reflector/compare/v0.12.1...v0.13.0) (2025-09-19)
+
+
+### Features
+
+* room form edit with enter ([#662](https://github.com/Monadical-SAS/reflector/issues/662)) ([47716f6](https://github.com/Monadical-SAS/reflector/commit/47716f6e5ddee952609d2fa0ffabdfa865286796))
+
+
+### Bug Fixes
+
+* invalid cleanup call ([#660](https://github.com/Monadical-SAS/reflector/issues/660)) ([0abcebf](https://github.com/Monadical-SAS/reflector/commit/0abcebfc9491f87f605f21faa3e53996fafedd9a))
+
 ## [0.12.1](https://github.com/Monadical-SAS/reflector/compare/v0.12.0...v0.12.1) (2025-09-17)
 
 

server/reflector/worker/cleanup.py

@@ -5,7 +5,6 @@ Deletes old anonymous transcripts and their associated meetings/recordings.
 Transcripts are the main entry point - any associated data is also removed.
 """
 
-import asyncio
 from datetime import datetime, timedelta, timezone
 from typing import TypedDict
 
@@ -226,5 +225,5 @@ async def cleanup_old_public_data(
     retry_kwargs={"max_retries": 3, "countdown": 300},
 )
 @asynctask
-def cleanup_old_public_data_task(days: int | None = None):
+async def cleanup_old_public_data_task(days: int | None = None):
-    asyncio.run(cleanup_old_public_data(days=days))
+    await cleanup_old_public_data(days=days)

server/reflector/worker/process.py

@@ -213,7 +213,6 @@ async def process_meetings():
                 should_deactivate = True
                 logger_.info(
                     "Meeting deactivated - scheduled time ended with no participants",
-                    meeting.id,
                 )
             else:
                 logger_.debug("Meeting not yet started, keep it")
@@ -224,8 +223,8 @@ async def process_meetings():
 
             processed_count += 1
 
-        except Exception as e:
+        except Exception:
-            logger_.error(f"Error processing meeting", exc_info=True)
+            logger_.error("Error processing meeting", exc_info=True)
         finally:
             try:
                 lock.release()
@@ -233,7 +232,7 @@ async def process_meetings():
                 pass  # Lock already released or expired
 
     logger.info(
-        f"Processed meetings finished",
+        "Processed meetings finished",
         processed_count=processed_count,
         skipped_count=skipped_count,
     )

www/.npmrc

@@ -0,0 +1 @@
+minimum-release-age=1440 #24hr in minutes

www/app/(app)/rooms/page.tsx

@@ -309,7 +309,7 @@ export default function RoomsList() {
 
       setRoomInput(null);
       setIsEditing(false);
-      setEditRoomId("");
+      setEditRoomId(null);
       setNameError("");
       refetch();
       onClose();
@@ -449,6 +449,13 @@ export default function RoomsList() {
               </Dialog.CloseTrigger>
             </Dialog.Header>
             <Dialog.Body>
+              <form
+                id="room-form"
+                onSubmit={(e) => {
+                  e.preventDefault();
+                  handleSaveRoom();
+                }}
+              >
                 <Tabs.Root defaultValue="general">
                   <Tabs.List>
                     <Tabs.Trigger value="general">General</Tabs.Trigger>
@@ -465,6 +472,7 @@ export default function RoomsList() {
                         placeholder="room-name"
                         value={room.name}
                         onChange={handleRoomChange}
+                        enterKeyHint="next"
                       />
                       <Field.HelperText>
                         No spaces or special characters allowed
@@ -496,7 +504,6 @@ export default function RoomsList() {
                         <Checkbox.Label>Locked room</Checkbox.Label>
                       </Checkbox.Root>
                     </Field.Root>
-
                     <Field.Root mt={4}>
                       <Field.Label>Room size</Field.Label>
                       <Select.Root
@@ -527,7 +534,6 @@ export default function RoomsList() {
                         </Select.Positioner>
                       </Select.Root>
                     </Field.Root>
-
                     <Field.Root mt={4}>
                       <Field.Label>Recording type</Field.Label>
                       <Select.Root
@@ -565,13 +571,15 @@ export default function RoomsList() {
                         </Select.Positioner>
                       </Select.Root>
                     </Field.Root>
-
                     <Field.Root mt={4}>
                       <Field.Label>Cloud recording start trigger</Field.Label>
                       <Select.Root
                         value={[room.recordingTrigger]}
                         onValueChange={(e) =>
-                        setRoomInput({ ...room, recordingTrigger: e.value[0] })
+                          setRoomInput({
+                            ...room,
+                            recordingTrigger: e.value[0],
+                          })
                         }
                         collection={recordingTriggerCollection}
                         disabled={room.recordingType !== "cloud"}
@@ -622,34 +630,6 @@ export default function RoomsList() {
                     </Field.Root>
                   </Tabs.Content>
 
-                <Tabs.Content value="calendar" pt={6}>
-                  <ICSSettings
-                    roomName={room.name ? parseNonEmptyString(room.name) : null}
-                    icsUrl={room.icsUrl}
-                    icsEnabled={room.icsEnabled}
-                    icsFetchInterval={room.icsFetchInterval}
-                    onChange={(settings) => {
-                      setRoomInput({
-                        ...room,
-                        icsUrl:
-                          settings.ics_url !== undefined
-                            ? settings.ics_url
-                            : room.icsUrl,
-                        icsEnabled:
-                          settings.ics_enabled !== undefined
-                            ? settings.ics_enabled
-                            : room.icsEnabled,
-                        icsFetchInterval:
-                          settings.ics_fetch_interval !== undefined
-                            ? settings.ics_fetch_interval
-                            : room.icsFetchInterval,
-                      });
-                    }}
-                    isOwner={true}
-                    isEditing={isEditing}
-                  />
-                </Tabs.Content>
-
                   <Tabs.Content value="share" pt={6}>
                     <Field.Root>
                       <Checkbox.Root
@@ -675,7 +655,6 @@ export default function RoomsList() {
                         </Checkbox.Label>
                       </Checkbox.Root>
                     </Field.Root>
-
                     <Field.Root mt={4}>
                       <Field.Label>Zulip stream</Field.Label>
                       <Select.Root
@@ -711,7 +690,6 @@ export default function RoomsList() {
                         </Select.Positioner>
                       </Select.Root>
                     </Field.Root>
-
                     <Field.Root mt={4}>
                       <Field.Label>Zulip topic</Field.Label>
                       <Select.Root
@@ -750,10 +728,10 @@ export default function RoomsList() {
                       <Field.Label>Webhook URL</Field.Label>
                       <Input
                         name="webhookUrl"
-                      type="url"
                         placeholder="https://example.com/webhook"
                         value={room.webhookUrl}
                         onChange={handleRoomChange}
+                        enterKeyHint="next"
                       />
                       <Field.HelperText>
                         Optional: URL to receive notifications when transcripts
@@ -832,7 +810,8 @@ export default function RoomsList() {
                                     maxWidth: "100%",
                                     padding: "8px",
                                     borderRadius: "4px",
-                                  backgroundColor: webhookTestResult.startsWith(
+                                    backgroundColor:
+                                      webhookTestResult.startsWith(
                                         SUCCESS_EMOJI,
                                       )
                                         ? "#f0fdf4"
@@ -849,15 +828,49 @@ export default function RoomsList() {
                       </>
                     )}
                   </Tabs.Content>
+
+                  <Tabs.Content value="calendar" pt={6}>
+                    <Field.Root>
+                      <ICSSettings
+                        roomName={
+                          room.name ? parseNonEmptyString(room.name) : null
+                        }
+                        icsUrl={room.icsUrl}
+                        icsEnabled={room.icsEnabled}
+                        icsFetchInterval={room.icsFetchInterval}
+                        onChange={(settings) => {
+                          setRoomInput({
+                            ...room,
+                            icsUrl:
+                              settings.ics_url !== undefined
+                                ? settings.ics_url
+                                : room.icsUrl,
+                            icsEnabled:
+                              settings.ics_enabled !== undefined
+                                ? settings.ics_enabled
+                                : room.icsEnabled,
+                            icsFetchInterval:
+                              settings.ics_fetch_interval !== undefined
+                                ? settings.ics_fetch_interval
+                                : room.icsFetchInterval,
+                          });
+                        }}
+                        isOwner={true}
+                        isEditing={isEditing}
+                      />
+                    </Field.Root>
+                  </Tabs.Content>
                 </Tabs.Root>
+              </form>
             </Dialog.Body>
             <Dialog.Footer>
               <Button variant="ghost" onClick={handleCloseDialog}>
                 Cancel
               </Button>
               <Button
+                type="submit"
                 colorPalette="primary"
-                onClick={handleSaveRoom}
+                form="room-form"
                 disabled={
                   !room.name || (room.zulipAutoPost && !room.zulipTopic)
                 }