whereby <-> consent accessibility

This commit is contained in:
Igor Loskutov
2025-06-19 11:36:05 -04:00
parent 92a08653aa
commit 66baf51ccb

View File

@@ -1,7 +1,7 @@
"use client"; "use client";
import "@whereby.com/browser-sdk/embed"; import "@whereby.com/browser-sdk/embed";
import { useCallback, useEffect, useRef, useState, useContext } from "react"; import { useCallback, useEffect, useRef, useState, useContext, RefObject } from "react";
import { Box, Button, Text, VStack, HStack, Spinner, useToast } from "@chakra-ui/react"; import { Box, Button, Text, VStack, HStack, Spinner, useToast } from "@chakra-ui/react";
import useRoomMeeting from "./useRoomMeeting"; import useRoomMeeting from "./useRoomMeeting";
import { useRouter } from "next/navigation"; import { useRouter } from "next/navigation";
@@ -17,7 +17,38 @@ export type RoomDetails = {
}; };
}; };
const useConsentDialog = (meetingId: string) => { // stages: we focus on the consent, then whereby steals focus, then we focus on the consent again, then return focus to whoever stole it initially
const useConsentWherebyFocusManagement = (acceptButtonRef: RefObject<HTMLButtonElement>, wherebyRef: RefObject<HTMLElement>) => {
const currentFocusRef = useRef<HTMLElement | null>(null);
useEffect(() => {
if (acceptButtonRef.current) {
acceptButtonRef.current.focus();
} else {
console.error("accept button ref not available yet for focus management - seems to be illegal state");
}
const handleWherebyReady = () => {
console.log("whereby ready - refocusing consent button");
currentFocusRef.current = document.activeElement as HTMLElement;
if (acceptButtonRef.current) {
acceptButtonRef.current.focus();
}
};
if (wherebyRef.current) {
wherebyRef.current.addEventListener("ready", handleWherebyReady);
} else {
console.warn("whereby ref not available yet for focus management - seems to be illegal state. not waiting, focus management off.");
}
return () => {
wherebyRef.current?.removeEventListener("ready", handleWherebyReady);
currentFocusRef.current?.focus();
};
}, []);
}
const useConsentDialog = (meetingId: string, wherebyRef: RefObject<HTMLElement>/*accessibility*/) => {
const { state: consentState, touch, hasConsent } = useRecordingConsent(); const { state: consentState, touch, hasConsent } = useRecordingConsent();
const [consentLoading, setConsentLoading] = useState(false); const [consentLoading, setConsentLoading] = useState(false);
const api = useApi(); const api = useApi();
@@ -41,7 +72,6 @@ const useConsentDialog = (meetingId: string) => {
} }
}, [api, touch]); }, [api, touch]);
// Show consent toast when meeting is loaded and consent hasn't been answered yet
useEffect(() => { useEffect(() => {
if ( if (
consentState.ready && consentState.ready &&
@@ -49,51 +79,73 @@ const useConsentDialog = (meetingId: string) => {
!hasConsent(meetingId) && !hasConsent(meetingId) &&
!consentLoading !consentLoading
) { ) {
const toastId = toast({ const toastId = toast({
position: "top", position: "top",
duration: null, duration: null,
render: ({ onClose }) => ( render: ({ onClose }) => {
<Box p={4} bg="white" borderRadius="md" boxShadow="md"> const AcceptButton = () => {
<VStack spacing={3} align="stretch"> const buttonRef = useRef<HTMLButtonElement>(null);
<Text> useConsentWherebyFocusManagement(buttonRef, wherebyRef);
Can we have your permission to store this meeting's audio recording on our servers? return (
</Text> <Button
<HStack spacing={4} justify="center"> ref={buttonRef}
<Button colorScheme="blue"
colorScheme="green" size="sm"
size="sm" onClick={() => {
onClick={() => { handleConsent(meetingId, true).then(() => {/*signifies it's ok to now wait here.*/})
handleConsent(meetingId, true).then(() => {/*signifies it's ok to now wait here.*/}) onClose()
onClose() }}
}} >
> Yes, store the audio
Yes, store the audio </Button>
</Button> );
<Button };
colorScheme="red"
size="sm" return (
onClick={() => { <Box p={6} bg="rgba(255, 255, 255, 0.7)" borderRadius="lg" boxShadow="lg" maxW="md" mx="auto">
handleConsent(meetingId, false).then(() => {/*signifies it's ok to now wait here.*/}) <VStack spacing={4} align="center">
onClose() <Text fontSize="md" textAlign="center" fontWeight="medium">
}} Can we have your permission to store this meeting's audio recording on our servers?
> </Text>
No, delete after transcription <HStack spacing={4} justify="center">
</Button> <AcceptButton />
</HStack> <Button
</VStack> colorScheme="gray"
</Box> size="sm"
), onClick={() => {
handleConsent(meetingId, false).then(() => {/*signifies it's ok to now wait here.*/})
onClose()
}}
>
No, delete after transcription
</Button>
</HStack>
</VStack>
</Box>
);
},
}); });
// Handle escape key to close the toast
const handleKeyDown = (event: KeyboardEvent) => {
if (event.key === 'Escape') {
toast.close(toastId);
}
};
document.addEventListener('keydown', handleKeyDown);
return () => { return () => {
toast.close(toastId); toast.close(toastId);
document.removeEventListener('keydown', handleKeyDown);
}; };
} }
}, [consentState.ready, meetingId, hasConsent, consentLoading, toast, handleConsent]); }, [consentState.ready, meetingId, hasConsent, consentLoading, toast, handleConsent]);
} }
function ConsentDialog({ meetingId }: { meetingId: string }) { function ConsentDialog({ meetingId, wherebyRef }: { meetingId: string; wherebyRef: React.RefObject<HTMLElement> }) {
useConsentDialog(meetingId); useConsentDialog(meetingId, wherebyRef);
return <></> return <></>
} }
@@ -134,10 +186,17 @@ export default function Room(details: RoomDetails) {
useEffect(() => { useEffect(() => {
if (isLoading || !isAuthenticated || !roomUrl) return; if (isLoading || !isAuthenticated || !roomUrl) return;
// accessibility: whereby grabs focus after its interface is loaded => we lose "esc" and keyboard control over the consent popup
const handleReady = (event: any) => {
console.log("whereby-embed ready event:", event);
};
wherebyRef.current?.addEventListener("leave", handleLeave); wherebyRef.current?.addEventListener("leave", handleLeave);
wherebyRef.current?.addEventListener("ready", handleReady);
return () => { return () => {
wherebyRef.current?.removeEventListener("leave", handleLeave); wherebyRef.current?.removeEventListener("leave", handleLeave);
wherebyRef.current?.removeEventListener("ready", handleReady);
}; };
}, [handleLeave, roomUrl, isLoading, isAuthenticated]); }, [handleLeave, roomUrl, isLoading, isAuthenticated]);
@@ -172,7 +231,7 @@ export default function Room(details: RoomDetails) {
room={roomUrl} room={roomUrl}
style={{ width: "100vw", height: "100vh" }} style={{ width: "100vw", height: "100vh" }}
/> />
{recordingType && recordingTypeRequiresConsent(recordingType) && <ConsentDialog meetingId={meetingId} />} {recordingType && recordingTypeRequiresConsent(recordingType) && <ConsentDialog meetingId={meetingId} wherebyRef={wherebyRef} />}
</> </>
)} )}
</> </>