From 6c4eac04c14f38f70250db8e3b14b9cd8b243ec6 Mon Sep 17 00:00:00 2001 From: Mathieu Virbel Date: Tue, 10 Sep 2024 18:35:33 -0600 Subject: [PATCH] fix: prevent unattended reloading on transcript page (#410) --- www/app/(app)/transcripts/useMp3.ts | 2 +- www/app/(app)/transcripts/useTopics.ts | 2 +- www/app/(app)/transcripts/useWaveform.ts | 2 +- www/app/(app)/transcripts/useWebRTC.ts | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/www/app/(app)/transcripts/useMp3.ts b/www/app/(app)/transcripts/useMp3.ts index 79f5b972..178c5089 100644 --- a/www/app/(app)/transcripts/useMp3.ts +++ b/www/app/(app)/transcripts/useMp3.ts @@ -52,7 +52,7 @@ const useMp3 = (id: string, waiting?: boolean): Mp3Response => { audioElement.preload = "auto"; setMedia(audioElement); setLoading(false); - }, [id, api, later]); + }, [id, !api, later]); const getNow = () => { setLater(false); diff --git a/www/app/(app)/transcripts/useTopics.ts b/www/app/(app)/transcripts/useTopics.ts index d0b0aaf4..ff17beaf 100644 --- a/www/app/(app)/transcripts/useTopics.ts +++ b/www/app/(app)/transcripts/useTopics.ts @@ -38,7 +38,7 @@ const useTopics = (id: string): TranscriptTopics => { setError(err); } }); - }, [id, api]); + }, [id, !api]); return { topics, loading, error }; }; diff --git a/www/app/(app)/transcripts/useWaveform.ts b/www/app/(app)/transcripts/useWaveform.ts index 709fd321..9139a2fb 100644 --- a/www/app/(app)/transcripts/useWaveform.ts +++ b/www/app/(app)/transcripts/useWaveform.ts @@ -36,7 +36,7 @@ const useWaveform = (id: string, waiting: boolean): AudioWaveFormResponse => { setError(err); } }); - }, [id, api, waiting]); + }, [id, !api, waiting]); return { waveform, loading, error }; }; diff --git a/www/app/(app)/transcripts/useWebRTC.ts b/www/app/(app)/transcripts/useWebRTC.ts index 9b4d57a0..c8370aa4 100644 --- a/www/app/(app)/transcripts/useWebRTC.ts +++ b/www/app/(app)/transcripts/useWebRTC.ts @@ -13,7 +13,7 @@ const useWebRTC = ( const api = useApi(); useEffect(() => { - if (!stream || !transcriptId) { + if (!stream || !transcriptId || !api) { return; } @@ -63,7 +63,7 @@ const useWebRTC = ( return () => { p.destroy(); }; - }, [stream, transcriptId]); + }, [stream, transcriptId, !api]); return peer; };