From 6c88e054238833808a8a56f8ee8a6d337e4712f0 Mon Sep 17 00:00:00 2001 From: Igor Loskutov Date: Thu, 5 Feb 2026 22:06:15 -0500 Subject: [PATCH] refactor: remove redundant fatalError ref, use state directly in handleLeave --- www/app/[roomName]/components/DailyRoom.tsx | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/www/app/[roomName]/components/DailyRoom.tsx b/www/app/[roomName]/components/DailyRoom.tsx index 61250e22..c64b6d18 100644 --- a/www/app/[roomName]/components/DailyRoom.tsx +++ b/www/app/[roomName]/components/DailyRoom.tsx @@ -254,7 +254,6 @@ export default function DailyRoom({ meeting, room }: DailyRoomProps) { const startRecordingMutation = useMeetingStartRecording(); const [joinedMeeting, setJoinedMeeting] = useState(null); const [fatalError, setFatalError] = useState(null); - const fatalErrorRef = useRef(null); // Generate deterministic instanceIds so all participants use SAME IDs const cloudInstanceId = parseNonEmptyString(meeting.id); @@ -302,16 +301,15 @@ export default function DailyRoom({ meeting, room }: DailyRoomProps) { const handleLeave = useCallback(() => { // If a fatal error occurred, don't redirect — let the error UI show - if (fatalErrorRef.current) return; + if (fatalError) return; router.push("/browse"); - }, [router]); + }, [router, fatalError]); const handleError = useCallback((ev: DailyEventObjectFatalError) => { const error: FatalError = { type: ev.error?.type ?? "unknown", message: ev.errorMsg, }; - fatalErrorRef.current = error; setFatalError(error); }, []);