From 84a381220bc606231d08d6f71d4babc818fa3c75 Mon Sep 17 00:00:00 2001
From: Mathieu Virbel <mat@meltingrocks.com>
Date: Fri, 29 Aug 2025 11:55:18 -0600
Subject: [PATCH] fix: make webhook secret/url allowing null (#590)

---
 ..._webhook_url_and_secret_null_by_default.py | 28 +++++++++++++++++++
 server/reflector/db/rooms.py                  |  8 +++---
 server/reflector/views/rooms.py               |  4 +--
 3 files changed, 34 insertions(+), 6 deletions(-)
 create mode 100644 server/migrations/versions/61882a919591_webhook_url_and_secret_null_by_default.py

diff --git a/server/migrations/versions/61882a919591_webhook_url_and_secret_null_by_default.py b/server/migrations/versions/61882a919591_webhook_url_and_secret_null_by_default.py
new file mode 100644
index 00000000..d02df839
--- /dev/null
+++ b/server/migrations/versions/61882a919591_webhook_url_and_secret_null_by_default.py
@@ -0,0 +1,28 @@
+"""webhook url and secret null by default
+
+
+Revision ID: 61882a919591
+Revises: 0194f65cd6d3
+Create Date: 2025-08-29 11:46:36.738091
+
+"""
+
+from typing import Sequence, Union
+
+# revision identifiers, used by Alembic.
+revision: str = "61882a919591"
+down_revision: Union[str, None] = "0194f65cd6d3"
+branch_labels: Union[str, Sequence[str], None] = None
+depends_on: Union[str, Sequence[str], None] = None
+
+
+def upgrade() -> None:
+    # ### commands auto generated by Alembic - please adjust! ###
+    pass
+    # ### end Alembic commands ###
+
+
+def downgrade() -> None:
+    # ### commands auto generated by Alembic - please adjust! ###
+    pass
+    # ### end Alembic commands ###
diff --git a/server/reflector/db/rooms.py b/server/reflector/db/rooms.py
index 08a6748d..abc45e61 100644
--- a/server/reflector/db/rooms.py
+++ b/server/reflector/db/rooms.py
@@ -41,8 +41,8 @@ rooms = sqlalchemy.Table(
     sqlalchemy.Column(
         "is_shared", sqlalchemy.Boolean, nullable=False, server_default=false()
     ),
-    sqlalchemy.Column("webhook_url", sqlalchemy.String),
-    sqlalchemy.Column("webhook_secret", sqlalchemy.String),
+    sqlalchemy.Column("webhook_url", sqlalchemy.String, nullable=True),
+    sqlalchemy.Column("webhook_secret", sqlalchemy.String, nullable=True),
     sqlalchemy.Index("idx_room_is_shared", "is_shared"),
 )
 
@@ -62,8 +62,8 @@ class Room(BaseModel):
         "none", "prompt", "automatic", "automatic-2nd-participant"
     ] = "automatic-2nd-participant"
     is_shared: bool = False
-    webhook_url: str = ""
-    webhook_secret: str = ""
+    webhook_url: str | None = None
+    webhook_secret: str | None = None
 
 
 class RoomController:
diff --git a/server/reflector/views/rooms.py b/server/reflector/views/rooms.py
index 82c172f2..40e81aeb 100644
--- a/server/reflector/views/rooms.py
+++ b/server/reflector/views/rooms.py
@@ -46,8 +46,8 @@ class Room(BaseModel):
 
 
 class RoomDetails(Room):
-    webhook_url: str
-    webhook_secret: str
+    webhook_url: str | None
+    webhook_secret: str | None
 
 
 class Meeting(BaseModel):