selfhostyourtech/reflector
2
0
Fork 0
mirror of https://github.com/Monadical-SAS/reflector.git synced 2025-12-20 20:29:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

self-review

Browse Source
This commit is contained in:
Igor Loskutov
2025-06-18 17:32:13 -04:00
parent 3acbcd9952
commit 9c20e8b9f6
3 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
server/reflector/db/transcripts.py
View File

@@ -70,6 +70,9 @@ transcripts = sqlalchemy.Table(
Enum(SourceKind, values_callable=lambda obj: [e.value for e in obj]), Enum(SourceKind, values_callable=lambda obj: [e.value for e in obj]),
nullable=False, nullable=False,
), ),
# indicative field: whether associated audio is deleted
# the main "audio deleted" is the presence of the audio itself / consents not-given
# same field could've been in recording/meeting, and it's maybe even ok to dupe it at need
sqlalchemy.Column("audio_deleted", sqlalchemy.Boolean, nullable=True), sqlalchemy.Column("audio_deleted", sqlalchemy.Boolean, nullable=True),
) )

9
server/reflector/pipelines/main_live_pipeline.py
View File

@@ -529,7 +529,7 @@ async def pipeline_upload_mp3(transcript: Transcript, logger: Logger):
return return
if transcript.audio_deleted: if transcript.audio_deleted:
logger.info("Skipping MP3 upload - audio marked as deleted") logger.info("Skipping mp3 upload - audio marked as deleted")
return return
logger.info("Starting upload mp3") logger.info("Starting upload mp3")
@@ -593,8 +593,7 @@ async def cleanup_consent(transcript: Transcript, logger: Logger):
logger.info("Consent denied, cleaning up all related audio files") logger.info("Consent denied, cleaning up all related audio files")
# 1. Delete original Whereby recording from S3 if recording and recording.bucket_name and recording.object_key:
if recording and recording.s3_bucket and recording.s3_key:
s3_whereby = boto3.client( s3_whereby = boto3.client(
"s3", "s3",
@@ -602,8 +601,8 @@ async def cleanup_consent(transcript: Transcript, logger: Logger):
aws_secret_access_key=settings.AWS_WHEREBY_ACCESS_KEY_SECRET, aws_secret_access_key=settings.AWS_WHEREBY_ACCESS_KEY_SECRET,
) )
try: try:
s3_whereby.delete_object(Bucket=recording.s3_bucket, Key=recording.s3_key) s3_whereby.delete_object(Bucket=recording.bucket_name, Key=recording.object_key)
logger.info(f"Deleted original Whereby recording: {recording.s3_bucket}/{recording.s3_key}") logger.info(f"Deleted original Whereby recording: {recording.bucket_name}/{recording.object_key}")
except Exception as e: except Exception as e:
logger.error(f"Failed to delete Whereby recording: {e}") logger.error(f"Failed to delete Whereby recording: {e}")

1
www/app/(app)/transcripts/useMp3.ts
View File

@@ -95,7 +95,6 @@ const useMp3 = (transcriptId: string, waiting?: boolean): Mp3Response => {
setTranscriptMetadataLoading(false); setTranscriptMetadataLoading(false);
}) })
// Cleanup
return () => { return () => {
stopped = true; stopped = true;
audioElement.removeEventListener('canplay', handleCanPlay); audioElement.removeEventListener('canplay', handleCanPlay);