refactor: add session parameter to ICSSyncService.sync_room_calendar

- Updated sync_room_calendar method to accept AsyncSession as first parameter
- Removed internal get_session_factory() calls from the service
- Updated all callers (views/rooms.py, worker/ics_sync.py) to pass session
- Fixed all test files to remove mocking of get_session_factory
- Consistent with @with_session decorator pattern used elsewhere

server/reflector/services/ics_sync.py

@@ -55,8 +55,8 @@ import httpx
 import pytz
 import structlog
 from icalendar import Calendar, Event
+from sqlalchemy.ext.asyncio import AsyncSession
 
-from reflector.db import get_session_factory
 from reflector.db.calendar_events import CalendarEvent, calendar_events_controller
 from reflector.db.rooms import Room, rooms_controller
 from reflector.redis_cache import RedisAsyncLock
@@ -295,7 +295,7 @@ class ICSSyncService:
     def __init__(self):
         self.fetch_service = ICSFetchService()
 
-    async def sync_room_calendar(self, room: Room) -> SyncResult:
+    async def sync_room_calendar(self, session: AsyncSession, room: Room) -> SyncResult:
         async with RedisAsyncLock(
             f"ics_sync_room:{room.id}", skip_if_locked=True
         ) as lock:
@@ -306,9 +306,11 @@ class ICSSyncService:
                     "reason": "Sync already in progress",
                 }
 
-            return await self._sync_room_calendar(room)
+            return await self._sync_room_calendar(session, room)
 
-    async def _sync_room_calendar(self, room: Room) -> SyncResult:
+    async def _sync_room_calendar(
+        self, session: AsyncSession, room: Room
+    ) -> SyncResult:
         if not room.ics_enabled or not room.ics_url:
             return {"status": SyncStatus.SKIPPED, "reason": "ICS not configured"}
 
@@ -341,20 +343,18 @@ class ICSSyncService:
             events, total_events = self.fetch_service.extract_room_events(
                 calendar, room.name, room_url
             )
-            sync_result = await self._sync_events_to_database(room.id, events)
+            sync_result = await self._sync_events_to_database(session, room.id, events)
 
             # Update room sync metadata
-            session_factory = get_session_factory()
-            async with session_factory() as session:
-                await rooms_controller.update(
-                    session,
-                    room,
-                    {
-                        "ics_last_sync": datetime.now(timezone.utc),
-                        "ics_last_etag": content_hash,
-                    },
-                    mutate=False,
-                )
+            await rooms_controller.update(
+                session,
+                room,
+                {
+                    "ics_last_sync": datetime.now(timezone.utc),
+                    "ics_last_etag": content_hash,
+                },
+                mutate=False,
+            )
 
             return {
                 "status": SyncStatus.SUCCESS,
@@ -376,34 +376,32 @@ class ICSSyncService:
         return time_since_sync.total_seconds() >= room.ics_fetch_interval
 
     async def _sync_events_to_database(
-        self, room_id: str, events: list[EventData]
+        self, session: AsyncSession, room_id: str, events: list[EventData]
     ) -> SyncStats:
         created = 0
         updated = 0
 
         current_ics_uids = []
 
-        session_factory = get_session_factory()
-        async with session_factory() as session:
-            for event_data in events:
-                calendar_event = CalendarEvent(room_id=room_id, **event_data)
-                existing = await calendar_events_controller.get_by_ics_uid(
-                    session, room_id, event_data["ics_uid"]
-                )
-
-                if existing:
-                    updated += 1
-                else:
-                    created += 1
-
-                await calendar_events_controller.upsert(session, calendar_event)
-                current_ics_uids.append(event_data["ics_uid"])
-
-            # Soft delete events that are no longer in calendar
-            deleted = await calendar_events_controller.soft_delete_missing(
-                session, room_id, current_ics_uids
+        for event_data in events:
+            calendar_event = CalendarEvent(room_id=room_id, **event_data)
+            existing = await calendar_events_controller.get_by_ics_uid(
+                session, room_id, event_data["ics_uid"]
             )
 
+            if existing:
+                updated += 1
+            else:
+                created += 1
+
+            await calendar_events_controller.upsert(session, calendar_event)
+            current_ics_uids.append(event_data["ics_uid"])
+
+        # Soft delete events that are no longer in calendar
+        deleted = await calendar_events_controller.soft_delete_missing(
+            session, room_id, current_ics_uids
+        )
+
         return {
             "events_created": created,
             "events_updated": updated,