From d0110f4dd437b854a131fa2a36d110b9ace221a2 Mon Sep 17 00:00:00 2001 From: Igor Loskutov Date: Fri, 23 Jan 2026 16:55:34 -0500 Subject: [PATCH] Fix: Remove redundant checks and clarify variable scope - Remove redundant padded_key None check (NonEmptyString cannot be None) - Move storage_path definition before try block for clarity - All padded tracks added to list (original or new) --- .../hatchet/workflows/daily_multitrack_pipeline.py | 13 ++++++------- .../reflector/hatchet/workflows/padding_workflow.py | 3 ++- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/server/reflector/hatchet/workflows/daily_multitrack_pipeline.py b/server/reflector/hatchet/workflows/daily_multitrack_pipeline.py index dd64a799..0d38e7fd 100644 --- a/server/reflector/hatchet/workflows/daily_multitrack_pipeline.py +++ b/server/reflector/hatchet/workflows/daily_multitrack_pipeline.py @@ -434,14 +434,13 @@ async def process_paddings(input: PipelineInput, ctx: Context) -> ProcessPadding for result in results: pad_result = PadTrackResult(**result[TaskName.PAD_TRACK]) - if pad_result.padded_key: - padded_tracks.append( - PaddedTrackInfo( - key=pad_result.padded_key, - bucket_name=pad_result.bucket_name, - track_index=pad_result.track_index, - ) + padded_tracks.append( + PaddedTrackInfo( + key=pad_result.padded_key, + bucket_name=pad_result.bucket_name, + track_index=pad_result.track_index, ) + ) if pad_result.size > 0: storage_path = f"file_pipeline_hatchet/{input.transcript_id}/tracks/padded_{pad_result.track_index}.webm" diff --git a/server/reflector/hatchet/workflows/padding_workflow.py b/server/reflector/hatchet/workflows/padding_workflow.py index fbfba18f..fa8225d4 100644 --- a/server/reflector/hatchet/workflows/padding_workflow.py +++ b/server/reflector/hatchet/workflows/padding_workflow.py @@ -94,6 +94,8 @@ async def pad_track(input: PaddingInput, ctx: Context) -> PadTrackResult: track_index=input.track_index, ) + storage_path = f"file_pipeline_hatchet/{input.transcript_id}/tracks/padded_{input.track_index}.webm" + with tempfile.NamedTemporaryFile(suffix=".webm", delete=False) as temp_file: temp_path = temp_file.name @@ -107,7 +109,6 @@ async def pad_track(input: PaddingInput, ctx: Context) -> PadTrackResult: ) file_size = Path(temp_path).stat().st_size - storage_path = f"file_pipeline_hatchet/{input.transcript_id}/tracks/padded_{input.track_index}.webm" with open(temp_path, "rb") as padded_file: await storage.put_file(storage_path, padded_file)