mirror of
https://github.com/Monadical-SAS/reflector.git
synced 2026-03-21 22:56:47 +00:00
a76f114378
* fix: move upd ports out of MacOS internal Range * feat: download files, show cloud video, solf deletion with no reprocessing
393 lines
14 KiB
Python
393 lines
14 KiB
Python
import pytest
|
|
|
|
from reflector.db.recordings import Recording, recordings_controller
|
|
from reflector.db.rooms import rooms_controller
|
|
from reflector.db.transcripts import SourceKind, transcripts_controller
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_transcript_create(monkeypatch, client):
|
|
from reflector.settings import settings
|
|
|
|
monkeypatch.setattr(
|
|
settings, "PUBLIC_MODE", True
|
|
) # public mode: allow anonymous transcript creation for this test
|
|
response = await client.post("/transcripts", json={"name": "test"})
|
|
assert response.status_code == 200
|
|
assert response.json()["name"] == "test"
|
|
assert response.json()["status"] == "idle"
|
|
assert response.json()["locked"] is False
|
|
assert response.json()["id"] is not None
|
|
assert response.json()["created_at"] is not None
|
|
|
|
# ensure some fields are not returned
|
|
assert "topics" not in response.json()
|
|
assert "events" not in response.json()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_transcript_get_update_name(authenticated_client, client):
|
|
response = await client.post("/transcripts", json={"name": "test"})
|
|
assert response.status_code == 200
|
|
assert response.json()["name"] == "test"
|
|
|
|
tid = response.json()["id"]
|
|
|
|
response = await client.get(f"/transcripts/{tid}")
|
|
assert response.status_code == 200
|
|
assert response.json()["name"] == "test"
|
|
|
|
response = await client.patch(f"/transcripts/{tid}", json={"name": "test2"})
|
|
assert response.status_code == 200
|
|
assert response.json()["name"] == "test2"
|
|
|
|
response = await client.get(f"/transcripts/{tid}")
|
|
assert response.status_code == 200
|
|
assert response.json()["name"] == "test2"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_transcript_get_update_locked(authenticated_client, client):
|
|
response = await client.post("/transcripts", json={"name": "test"})
|
|
assert response.status_code == 200
|
|
assert response.json()["locked"] is False
|
|
|
|
tid = response.json()["id"]
|
|
|
|
response = await client.get(f"/transcripts/{tid}")
|
|
assert response.status_code == 200
|
|
assert response.json()["locked"] is False
|
|
|
|
response = await client.patch(f"/transcripts/{tid}", json={"locked": True})
|
|
assert response.status_code == 200
|
|
assert response.json()["locked"] is True
|
|
|
|
response = await client.get(f"/transcripts/{tid}")
|
|
assert response.status_code == 200
|
|
assert response.json()["locked"] is True
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_transcript_get_update_summary(authenticated_client, client):
|
|
response = await client.post("/transcripts", json={"name": "test"})
|
|
assert response.status_code == 200
|
|
assert response.json()["long_summary"] is None
|
|
assert response.json()["short_summary"] is None
|
|
|
|
tid = response.json()["id"]
|
|
|
|
response = await client.get(f"/transcripts/{tid}")
|
|
assert response.status_code == 200
|
|
assert response.json()["long_summary"] is None
|
|
assert response.json()["short_summary"] is None
|
|
|
|
response = await client.patch(
|
|
f"/transcripts/{tid}",
|
|
json={"long_summary": "test_long", "short_summary": "test_short"},
|
|
)
|
|
assert response.status_code == 200
|
|
assert response.json()["long_summary"] == "test_long"
|
|
assert response.json()["short_summary"] == "test_short"
|
|
|
|
response = await client.get(f"/transcripts/{tid}")
|
|
assert response.status_code == 200
|
|
assert response.json()["long_summary"] == "test_long"
|
|
assert response.json()["short_summary"] == "test_short"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_transcript_get_update_title(authenticated_client, client):
|
|
response = await client.post("/transcripts", json={"name": "test"})
|
|
assert response.status_code == 200
|
|
assert response.json()["title"] is None
|
|
|
|
tid = response.json()["id"]
|
|
|
|
response = await client.get(f"/transcripts/{tid}")
|
|
assert response.status_code == 200
|
|
assert response.json()["title"] is None
|
|
|
|
response = await client.patch(f"/transcripts/{tid}", json={"title": "test_title"})
|
|
assert response.status_code == 200
|
|
assert response.json()["title"] == "test_title"
|
|
|
|
response = await client.get(f"/transcripts/{tid}")
|
|
assert response.status_code == 200
|
|
assert response.json()["title"] == "test_title"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_set_status_emits_status_event_and_updates_transcript(
|
|
monkeypatch, client
|
|
):
|
|
"""set_status adds a STATUS event and updates the transcript status (broadcast for WebSocket)."""
|
|
from reflector.settings import settings
|
|
|
|
monkeypatch.setattr(
|
|
settings, "PUBLIC_MODE", True
|
|
) # public mode: allow anonymous transcript creation for this test
|
|
response = await client.post("/transcripts", json={"name": "Status test"})
|
|
assert response.status_code == 200
|
|
transcript_id = response.json()["id"]
|
|
|
|
transcript = await transcripts_controller.get_by_id(transcript_id)
|
|
assert transcript is not None
|
|
assert transcript.status == "idle"
|
|
|
|
event = await transcripts_controller.set_status(transcript_id, "processing")
|
|
assert event is not None
|
|
assert event.event == "STATUS"
|
|
assert event.data.get("value") == "processing"
|
|
|
|
updated = await transcripts_controller.get_by_id(transcript_id)
|
|
assert updated.status == "processing"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_transcripts_list_anonymous(client):
|
|
# XXX this test is a bit fragile, as it depends on the storage which
|
|
# is shared between tests
|
|
from reflector.settings import settings
|
|
|
|
response = await client.get("/transcripts")
|
|
assert response.status_code == 401
|
|
|
|
# if public mode, it should be allowed
|
|
try:
|
|
settings.PUBLIC_MODE = True
|
|
response = await client.get("/transcripts")
|
|
assert response.status_code == 200
|
|
finally:
|
|
settings.PUBLIC_MODE = False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_transcripts_list_authenticated(authenticated_client, client):
|
|
# XXX this test is a bit fragile, as it depends on the storage which
|
|
# is shared between tests
|
|
|
|
response = await client.post("/transcripts", json={"name": "testxx1"})
|
|
assert response.status_code == 200
|
|
assert response.json()["name"] == "testxx1"
|
|
|
|
response = await client.post("/transcripts", json={"name": "testxx2"})
|
|
assert response.status_code == 200
|
|
assert response.json()["name"] == "testxx2"
|
|
|
|
response = await client.get("/transcripts")
|
|
assert response.status_code == 200
|
|
assert len(response.json()["items"]) >= 2
|
|
names = [t["name"] for t in response.json()["items"]]
|
|
assert "testxx1" in names
|
|
assert "testxx2" in names
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_transcript_delete(authenticated_client, client):
|
|
response = await client.post("/transcripts", json={"name": "testdel1"})
|
|
assert response.status_code == 200
|
|
assert response.json()["name"] == "testdel1"
|
|
|
|
tid = response.json()["id"]
|
|
response = await client.delete(f"/transcripts/{tid}")
|
|
assert response.status_code == 200
|
|
assert response.json()["status"] == "ok"
|
|
|
|
# API returns 404 for soft-deleted transcripts
|
|
response = await client.get(f"/transcripts/{tid}")
|
|
assert response.status_code == 404
|
|
|
|
# But the transcript still exists in DB with deleted_at set
|
|
transcript = await transcripts_controller.get_by_id(tid)
|
|
assert transcript is not None
|
|
assert transcript.deleted_at is not None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_deleted_transcript_not_in_list(authenticated_client, client):
|
|
"""Soft-deleted transcripts should not appear in the list endpoint."""
|
|
response = await client.post("/transcripts", json={"name": "testdel_list"})
|
|
assert response.status_code == 200
|
|
tid = response.json()["id"]
|
|
|
|
# Verify it appears in the list
|
|
response = await client.get("/transcripts")
|
|
assert response.status_code == 200
|
|
ids = [t["id"] for t in response.json()["items"]]
|
|
assert tid in ids
|
|
|
|
# Delete it
|
|
response = await client.delete(f"/transcripts/{tid}")
|
|
assert response.status_code == 200
|
|
|
|
# Verify it no longer appears in the list
|
|
response = await client.get("/transcripts")
|
|
assert response.status_code == 200
|
|
ids = [t["id"] for t in response.json()["items"]]
|
|
assert tid not in ids
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_delete_already_deleted_is_idempotent(authenticated_client, client):
|
|
"""Deleting an already-deleted transcript is idempotent (returns 200)."""
|
|
response = await client.post("/transcripts", json={"name": "testdel_idem"})
|
|
assert response.status_code == 200
|
|
tid = response.json()["id"]
|
|
|
|
# First delete
|
|
response = await client.delete(f"/transcripts/{tid}")
|
|
assert response.status_code == 200
|
|
|
|
# Second delete — idempotent, still returns ok
|
|
response = await client.delete(f"/transcripts/{tid}")
|
|
assert response.status_code == 200
|
|
|
|
# But deleted_at was only set once (not updated)
|
|
transcript = await transcripts_controller.get_by_id(tid)
|
|
assert transcript is not None
|
|
assert transcript.deleted_at is not None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_deleted_transcript_recording_soft_deleted(authenticated_client, client):
|
|
"""Soft-deleting a transcript also soft-deletes its recording."""
|
|
from datetime import datetime, timezone
|
|
|
|
recording = await recordings_controller.create(
|
|
Recording(
|
|
bucket_name="test-bucket",
|
|
object_key="test.mp4",
|
|
recorded_at=datetime.now(timezone.utc),
|
|
)
|
|
)
|
|
transcript = await transcripts_controller.add(
|
|
name="with-recording",
|
|
source_kind=SourceKind.ROOM,
|
|
recording_id=recording.id,
|
|
user_id="randomuserid",
|
|
)
|
|
|
|
response = await client.delete(f"/transcripts/{transcript.id}")
|
|
assert response.status_code == 200
|
|
|
|
# Recording still in DB with deleted_at set
|
|
rec = await recordings_controller.get_by_id(recording.id)
|
|
assert rec is not None
|
|
assert rec.deleted_at is not None
|
|
|
|
# Transcript still in DB with deleted_at set
|
|
tr = await transcripts_controller.get_by_id(transcript.id)
|
|
assert tr is not None
|
|
assert tr.deleted_at is not None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_transcript_mark_reviewed(authenticated_client, client):
|
|
response = await client.post("/transcripts", json={"name": "test"})
|
|
assert response.status_code == 200
|
|
assert response.json()["name"] == "test"
|
|
assert response.json()["reviewed"] is False
|
|
|
|
tid = response.json()["id"]
|
|
|
|
response = await client.get(f"/transcripts/{tid}")
|
|
assert response.status_code == 200
|
|
assert response.json()["name"] == "test"
|
|
assert response.json()["reviewed"] is False
|
|
|
|
response = await client.patch(f"/transcripts/{tid}", json={"reviewed": True})
|
|
assert response.status_code == 200
|
|
assert response.json()["reviewed"] is True
|
|
|
|
response = await client.get(f"/transcripts/{tid}")
|
|
assert response.status_code == 200
|
|
assert response.json()["reviewed"] is True
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_transcript_get_returns_room_name(authenticated_client, client):
|
|
"""Test that getting a transcript returns its room_name when linked to a room."""
|
|
# Create a room
|
|
room = await rooms_controller.add(
|
|
name="test-room-for-transcript",
|
|
user_id="test-user",
|
|
zulip_auto_post=False,
|
|
zulip_stream="",
|
|
zulip_topic="",
|
|
is_locked=False,
|
|
room_mode="normal",
|
|
recording_type="cloud",
|
|
recording_trigger="automatic-2nd-participant",
|
|
is_shared=False,
|
|
webhook_url="",
|
|
webhook_secret="",
|
|
)
|
|
|
|
# Create a transcript linked to the room
|
|
transcript = await transcripts_controller.add(
|
|
name="transcript-with-room",
|
|
source_kind="file",
|
|
room_id=room.id,
|
|
)
|
|
|
|
# Get the transcript and verify room_name is returned
|
|
response = await client.get(f"/transcripts/{transcript.id}")
|
|
assert response.status_code == 200
|
|
assert response.json()["room_id"] == room.id
|
|
assert response.json()["room_name"] == "test-room-for-transcript"
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_transcript_get_returns_null_room_name_when_no_room(
|
|
authenticated_client, client
|
|
):
|
|
"""Test that room_name is null when transcript has no room."""
|
|
response = await client.post("/transcripts", json={"name": "no-room-transcript"})
|
|
assert response.status_code == 200
|
|
tid = response.json()["id"]
|
|
|
|
response = await client.get(f"/transcripts/{tid}")
|
|
assert response.status_code == 200
|
|
assert response.json()["room_id"] is None
|
|
assert response.json()["room_name"] is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_transcripts_list_filtered_by_room_id(authenticated_client, client):
|
|
"""GET /transcripts?room_id=X returns only transcripts for that room."""
|
|
# Use same user as authenticated_client (conftest uses "randomuserid")
|
|
user_id = "randomuserid"
|
|
room = await rooms_controller.add(
|
|
name="room-for-list-filter",
|
|
user_id=user_id,
|
|
zulip_auto_post=False,
|
|
zulip_stream="",
|
|
zulip_topic="",
|
|
is_locked=False,
|
|
room_mode="normal",
|
|
recording_type="cloud",
|
|
recording_trigger="automatic-2nd-participant",
|
|
is_shared=False,
|
|
webhook_url="",
|
|
webhook_secret="",
|
|
)
|
|
in_room = await transcripts_controller.add(
|
|
name="in-room",
|
|
source_kind="file",
|
|
room_id=room.id,
|
|
user_id=user_id,
|
|
)
|
|
other = await transcripts_controller.add(
|
|
name="no-room",
|
|
source_kind="file",
|
|
room_id=None,
|
|
user_id=user_id,
|
|
)
|
|
|
|
response = await client.get("/transcripts", params={"room_id": room.id})
|
|
assert response.status_code == 200
|
|
items = response.json()["items"]
|
|
ids = [t["id"] for t in items]
|
|
assert in_room.id in ids
|
|
assert other.id not in ids
|