selfhostyourtech/reflector
2
0
Fork 0
mirror of https://github.com/Monadical-SAS/reflector.git synced 2026-02-06 10:46:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: address review feedback - use ApiError type, move inline imports

Browse Source
This commit is contained in:
Igor Loskutov
2026-02-05 18:50:12 -05:00
parent 1da687fe13
commit 238d768499
2 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
server/tests/test_ics_dedup.py
View File

@@ -3,6 +3,7 @@ from unittest.mock import AsyncMock, patch
import pytest import pytest
from reflector.db import get_database
from reflector.db.calendar_events import CalendarEvent, calendar_events_controller from reflector.db.calendar_events import CalendarEvent, calendar_events_controller
from reflector.db.meetings import meetings from reflector.db.meetings import meetings
from reflector.db.rooms import rooms_controller from reflector.db.rooms import rooms_controller
@@ -64,8 +65,6 @@ async def test_duplicate_calendar_event_does_not_create_duplicate_meeting():
await create_upcoming_meetings_for_event(event1, create_window, room) await create_upcoming_meetings_for_event(event1, create_window, room)
# Verify meeting was created # Verify meeting was created
from reflector.db import get_database
results = await get_database().fetch_all( results = await get_database().fetch_all(
meetings.select().where(meetings.c.room_id == room.id) meetings.select().where(meetings.c.room_id == room.id)
) )
@@ -176,8 +175,6 @@ async def test_different_time_windows_create_separate_meetings():
await create_upcoming_meetings_for_event(event1, create_window, room) await create_upcoming_meetings_for_event(event1, create_window, room)
await create_upcoming_meetings_for_event(event2, create_window, room) await create_upcoming_meetings_for_event(event2, create_window, room)
from reflector.db import get_database
results = await get_database().fetch_all( results = await get_database().fetch_all(
meetings.select().where(meetings.c.room_id == room.id) meetings.select().where(meetings.c.room_id == room.id)
) )

8
www/app/[roomName]/components/DailyRoom.tsx
View File

@@ -21,7 +21,7 @@ import DailyIframe, {
DailyParticipantsObject, DailyParticipantsObject,
} from "@daily-co/daily-js"; } from "@daily-co/daily-js";
import type { components } from "../../reflector-api"; import type { components } from "../../reflector-api";
import { printApiError } from "../../api/_error"; import { printApiError, ApiError } from "../../api/_error";
import { useAuth } from "../../lib/AuthProvider"; import { useAuth } from "../../lib/AuthProvider";
import { useConsentDialog } from "../../lib/consent"; import { useConsentDialog } from "../../lib/consent";
import { import {
@@ -401,11 +401,7 @@ export default function DailyRoom({ meeting, room }: DailyRoomProps) {
} }
if (joinMutation.isError) { if (joinMutation.isError) {
const apiDetail = printApiError( const apiDetail = printApiError(joinMutation.error as ApiError);
joinMutation.error as {
detail?: components["schemas"]["ValidationError"][];
} | null,
);
return ( return (
<Center width="100vw" height="100vh"> <Center width="100vw" height="100vh">
<VStack gap={4}> <VStack gap={4}>