Merge pull request #459 from Monadical-SAS/fix-room-not-found

Fix room not found error
This commit is contained in:
2025-02-10 16:42:27 +01:00
committed by GitHub
3 changed files with 15 additions and 3 deletions

View File

@@ -1,9 +1,8 @@
from datetime import datetime, timedelta
from http.client import HTTPException
from typing import Annotated, Optional
import reflector.auth as auth
from fastapi import APIRouter, Depends
from fastapi import APIRouter, Depends, HTTPException
from fastapi_pagination import Page
from fastapi_pagination.ext.databases import paginate
from pydantic import BaseModel

View File

@@ -5,6 +5,7 @@ import { useCallback, useEffect, useRef, useState } from "react";
import { Box, Button, Text, VStack, HStack, Spinner } from "@chakra-ui/react";
import useRoomMeeting from "./useRoomMeeting";
import { useRouter } from "next/navigation";
import { notFound } from "next/navigation";
import useSessionStatus from "../lib/useSessionStatus";
export type RoomDetails = {
@@ -34,6 +35,17 @@ export default function Room(details: RoomDetails) {
setConsentGiven(consent);
};
useEffect(() => {
if (
!isLoading &&
meeting?.error &&
"status" in meeting.error &&
meeting.error.status === 404
) {
notFound();
}
}, [isLoading, meeting?.error]);
useEffect(() => {
if (isLoading || !isAuthenticated || !roomUrl) return;

View File

@@ -3,6 +3,7 @@ import { useError } from "../(errors)/errorContext";
import { Meeting } from "../api";
import { shouldShowError } from "../lib/errorUtils";
import useApi from "../lib/useApi";
import { notFound } from "next/navigation";
type ErrorMeeting = {
error: Error;
@@ -52,7 +53,7 @@ const useRoomMeeting = (
})
.catch((error) => {
const shouldShowHuman = shouldShowError(error);
if (shouldShowHuman) {
if (shouldShowHuman && error.status !== 404) {
setError(
error,
"There was an error loading the meeting. Please try again by refreshing the page."