mirror of
https://github.com/Monadical-SAS/reflector.git
synced 2026-02-04 18:06:48 +00:00
316f7b316d
- Import topics_to_webvtt_named and recordings controller - Add _get_is_multitrack helper function - Generate WebVTT context on WebSocket connection - Add get_context message type to retrieve WebVTT - Maintain backward compatibility with echo for other messages - Add test fixture and test for WebVTT context generation Implements task fn-1.2: WebVTT context generation for transcript chat
33 lines
1.4 KiB
Markdown
33 lines
1.4 KiB
Markdown
# fn-1.2 WebVTT context generation
|
|
|
|
## Description
|
|
TBD
|
|
|
|
## Acceptance
|
|
- [ ] TBD
|
|
|
|
## Done summary
|
|
- Implemented WebVTT context generation in transcript chat WebSocket endpoint
|
|
- Added `_get_is_multitrack()` helper to detect multitrack recordings
|
|
- WebVTT generated on connection using existing `topics_to_webvtt_named()` utility
|
|
- Added `get_context` message type to retrieve WebVTT context
|
|
- Maintained backward compatibility with echo functionality
|
|
- Created test fixture `test_transcript_with_content` with participants and words
|
|
- Added test for WebVTT context generation via get_context message
|
|
|
|
**Why:**
|
|
- Provides transcript context for LLM integration in next task (fn-1.3)
|
|
- Reuses existing, well-tested WebVTT generation utility
|
|
- Supports both multitrack and standard recordings
|
|
|
|
**Verification:**
|
|
- Core WebVTT generation tested: `pytest tests/test_transcript_formats.py::test_topics_to_webvtt_named` passes
|
|
- Linting clean: no ruff errors on changed files
|
|
- WebSocket tests have pre-existing infrastructure issue (async pool) affecting all tests, not related to changes
|
|
|
|
**Note:**
|
|
WebSocket tests fail due to pre-existing test infrastructure issue with asyncpg pool cleanup. This affects all WebSocket tests, not just the new test. Core functionality verified via unit test of `topics_to_webvtt_named()`.
|
|
## Evidence
|
|
- Commits: dbb619e7fcf50634c6bc7b7a355183de2243131b
|
|
- Tests: pytest tests/test_transcript_formats.py::test_topics_to_webvtt_named
|
|
- PRs: |