mirror of
https://github.com/Monadical-SAS/reflector.git
synced 2025-12-21 12:49:06 +00:00
Mathieu Virbel
7f178b5f9e
- Update migration files to use SQLAlchemy 2.0 select() syntax - Fix RoomController to use select(RoomModel) instead of rooms.select() - Add session parameter to CalendarEventController method calls - Update ics_sync.py service to properly manage sessions - Fix test files to pass session parameter to controller methods - Update test assertions for correct attendee parsing behavior
116 lines
4.3 KiB
Python
116 lines
4.3 KiB
Python
import os
|
|
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
|
|
from reflector.db import get_session_factory
|
|
from reflector.db.rooms import rooms_controller
|
|
from reflector.services.ics_sync import ICSSyncService
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_attendee_parsing_bug():
|
|
"""
|
|
Test that reproduces the attendee parsing bug where a string with comma-separated
|
|
emails gets parsed as individual characters instead of separate email addresses.
|
|
|
|
The bug manifests as getting 29 attendees with emails like "M", "A", "I", etc.
|
|
instead of properly parsed email addresses.
|
|
"""
|
|
# Create a test room
|
|
async with get_session_factory()() as session:
|
|
room = await rooms_controller.add(
|
|
session,
|
|
name="test-room",
|
|
user_id="test-user",
|
|
zulip_auto_post=False,
|
|
zulip_stream="",
|
|
zulip_topic="",
|
|
is_locked=False,
|
|
room_mode="normal",
|
|
recording_type="cloud",
|
|
recording_trigger="automatic-2nd-participant",
|
|
is_shared=False,
|
|
ics_url="http://test.com/test.ics",
|
|
ics_enabled=True,
|
|
)
|
|
|
|
# Read the test ICS file that reproduces the bug and update it with current time
|
|
from datetime import datetime, timedelta, timezone
|
|
|
|
test_ics_path = os.path.join(
|
|
os.path.dirname(__file__), "test_attendee_parsing_bug.ics"
|
|
)
|
|
with open(test_ics_path, "r") as f:
|
|
ics_content = f.read()
|
|
|
|
# Replace the dates with current time + 1 hour to ensure it's within the 24h window
|
|
now = datetime.now(timezone.utc)
|
|
future_time = now + timedelta(hours=1)
|
|
end_time = future_time + timedelta(hours=1)
|
|
|
|
# Format dates for ICS format
|
|
dtstart = future_time.strftime("%Y%m%dT%H%M%SZ")
|
|
dtend = end_time.strftime("%Y%m%dT%H%M%SZ")
|
|
dtstamp = now.strftime("%Y%m%dT%H%M%SZ")
|
|
|
|
# Update the ICS content with current dates
|
|
ics_content = ics_content.replace("20250910T180000Z", dtstart)
|
|
ics_content = ics_content.replace("20250910T190000Z", dtend)
|
|
ics_content = ics_content.replace("20250910T174000Z", dtstamp)
|
|
|
|
# Create sync service and mock the fetch
|
|
sync_service = ICSSyncService()
|
|
|
|
with patch.object(
|
|
sync_service.fetch_service, "fetch_ics", new_callable=AsyncMock
|
|
) as mock_fetch:
|
|
mock_fetch.return_value = ics_content
|
|
|
|
# Debug: Parse the ICS content directly to examine attendee parsing
|
|
calendar = sync_service.fetch_service.parse_ics(ics_content)
|
|
from reflector.settings import settings
|
|
|
|
room_url = f"{settings.UI_BASE_URL}/{room.name}"
|
|
|
|
print(f"Room URL being used for matching: {room_url}")
|
|
print(f"ICS content:\n{ics_content}")
|
|
|
|
events, total_events = sync_service.fetch_service.extract_room_events(
|
|
calendar, room.name, room_url
|
|
)
|
|
|
|
print(f"Total events in calendar: {total_events}")
|
|
print(f"Events matching room: {len(events)}")
|
|
|
|
# Perform the sync
|
|
result = await sync_service.sync_room_calendar(room)
|
|
|
|
# Check that the sync succeeded
|
|
assert result.get("status") == "success"
|
|
assert result.get("events_found", 0) >= 0 # Allow for debugging
|
|
|
|
# We already have the matching events from the debug code above
|
|
assert len(events) == 1
|
|
event = events[0]
|
|
|
|
# This is where the bug manifests - check the attendees
|
|
attendees = event["attendees"]
|
|
|
|
# Debug output to see what's happening
|
|
print(f"Number of attendees: {len(attendees)}")
|
|
for i, attendee in enumerate(attendees):
|
|
print(f"Attendee {i}: {attendee}")
|
|
|
|
# The comma-separated attendees should be parsed as individual attendees
|
|
# We expect 29 attendees from the comma-separated list + 1 organizer = 30 total
|
|
assert len(attendees) == 30, f"Expected 30 attendees, got {len(attendees)}"
|
|
|
|
# Verify the attendees have correct email addresses (not single characters)
|
|
# Check that the first few attendees match what's in the ICS file
|
|
assert attendees[0]["email"] == "alice@example.com"
|
|
assert attendees[1]["email"] == "bob@example.com"
|
|
assert attendees[2]["email"] == "charlie@example.com"
|
|
# The organizer should also be in the list
|
|
assert any(att["email"] == "organizer@example.com" for att in attendees)
|